Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some packages need native compilers #25294

Merged
merged 2 commits into from
Feb 20, 2024
Merged

Some packages need native compilers #25294

merged 2 commits into from
Feb 20, 2024

Conversation

mseri
Copy link
Member

@mseri mseri commented Feb 19, 2024

Seen on #25268

Fails with
```
=== ERROR while compiling alt-ergo.2.5.2 =====================================#
 context              2.2.0~beta2~dev | linux/arm32 | ocaml-base-compiler.5.1.1 | file:///home/opam/opam-repository
 path                 ~/.opam/5.1/.opam-switch/build/alt-ergo.2.5.2
 command              ~/.opam/opam-init/hooks/sandbox.sh build dune build -p alt-ergo -j 79 --promote-install-files=false @install
 exit-code            1
 env-file             ~/.opam/log/alt-ergo-7-7876d6.env
 output-file          ~/.opam/log/alt-ergo-7-7876d6.out
 File "src/plugins/fm-simplex/dune", line 15, characters 2-22:
 15 |   FmSimplexPlugin.cmxs))
        ^^^^^^^^^^^^^^^^^^^^
 Error: No rule found for src/plugins/fm-simplex/FmSimplexPlugin.cmxs
```
Fails with
```
ocamlfind: Not supported in your configuration: ocamlopt
ocamlfind: Not supported in your configuration: ocamlopt
```

Signed-off-by: Marcello Seri <[email protected]>
@mseri mseri merged commit f2c29f9 into ocaml:master Feb 20, 2024
1 of 2 checks passed
@mseri mseri deleted the bytes branch February 20, 2024 16:46
bclement-ocp added a commit to bclement-ocp/alt-ergo that referenced this pull request Mar 1, 2024
We already use dune-site to manage plugin files. With this patch, we now
also use the dune-site mechanism to manage plugin loading for the
inequalities plugin. This should make alt-ergo work with bytecode-only
compilers again (see [1]).

We still use Dynlink directly for additional parsers. Support for parser
plugins is deprecated as it is not supported with the Dolmen frontend
and will be removed in a future release, so the churn doesn't seem worth
it.

Fixes OCamlPro#1047

[1] : ocaml/opam-repository#25294
bclement-ocp added a commit to bclement-ocp/alt-ergo that referenced this pull request Mar 1, 2024
We already use dune-site to manage plugin files. With this patch, we now
also use the dune-site mechanism to manage plugin loading for the
inequalities plugin. This should make alt-ergo work with bytecode-only
compilers again (see [1]).

We still use Dynlink directly for additional parsers. Support for parser
plugins is deprecated as it is not supported with the Dolmen frontend
and will be removed in a future release, so the churn doesn't seem worth
it.

Fixes OCamlPro#1047

[1] : ocaml/opam-repository#25294
bclement-ocp added a commit to bclement-ocp/alt-ergo that referenced this pull request Mar 1, 2024
We already use dune-site to manage plugin files. With this patch, we now
also use the dune-site mechanism to manage plugin loading for the
inequalities plugin. This should make alt-ergo work with bytecode-only
compilers again (see [1]).

We still use Dynlink directly for additional parsers. Support for parser
plugins is deprecated as it is not supported with the Dolmen frontend
and will be removed in a future release, so the churn doesn't seem worth
it.

Fixes OCamlPro#1047

[1] : ocaml/opam-repository#25294
bclement-ocp added a commit to bclement-ocp/alt-ergo that referenced this pull request Mar 1, 2024
We already use dune-site to manage plugin files. With this patch, we now
also use the dune-site mechanism to manage plugin loading for the
inequalities plugin. This should make alt-ergo work with bytecode-only
compilers again (see [1]).

We still use Dynlink directly for additional parsers. Support for parser
plugins is deprecated as it is not supported with the Dolmen frontend
and will be removed in a future release, so the churn doesn't seem worth
it.

Fixes OCamlPro#1047

[1] : ocaml/opam-repository#25294
bclement-ocp added a commit to bclement-ocp/alt-ergo that referenced this pull request Mar 13, 2024
We already use dune-site to manage plugin files. With this patch, we now
also use the dune-site mechanism to manage plugin loading for the
inequalities plugin. This should make alt-ergo work with bytecode-only
compilers again (see [1]).

We still use Dynlink directly for additional parsers. Support for parser
plugins is deprecated as it is not supported with the Dolmen frontend
and will be removed in a future release, so the churn doesn't seem worth
it.

Fixes OCamlPro#1047

[1] : ocaml/opam-repository#25294
bclement-ocp added a commit to OCamlPro/alt-ergo that referenced this pull request Mar 13, 2024
We already use dune-site to manage plugin files. With this patch, we now
also use the dune-site mechanism to manage plugin loading for the
inequalities plugin. This should make alt-ergo work with bytecode-only
compilers again (see [1]).

We still use Dynlink directly for additional parsers. Support for parser
plugins is deprecated as it is not supported with the Dolmen frontend
and will be removed in a future release, so the churn doesn't seem worth
it.

Fixes #1047

[1] : ocaml/opam-repository#25294
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant