Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ocamlfuse.2.7.1-cvs8 #23728

Merged
merged 2 commits into from
May 24, 2023
Merged

Add ocamlfuse.2.7.1-cvs8 #23728

merged 2 commits into from
May 24, 2023

Conversation

astrada
Copy link
Contributor

@astrada astrada commented Apr 27, 2023

No description provided.

@mseri
Copy link
Member

mseri commented Apr 28, 2023

On the repo it is marked as pre-release: https://github.com/astrada/ocamlfuse/releases
Is that expected?

Looks like it is broken on macos/arm64:

#=== ERROR while compiling ocamlfuse.2.7.1-cvs8 ===============================#
# context              2.1.4 | macos/arm64 | ocaml-base-compiler.5.0.0 | pinned(https://github.com/astrada/ocamlfuse/archive/v2.7.1_cvs8.tar.gz)
# path                 ~/.opam/5.0.0/.opam-switch/build/ocamlfuse.2.7.1-cvs8
# command              ~/.opam/opam-init/hooks/sandbox.sh build dune build -p ocamlfuse -j 7 @install
# exit-code            1
# env-file             ~/.opam/log/ocamlfuse-86053-63ce51.env
# output-file          ~/.opam/log/ocamlfuse-86053-63ce51.out
### output ###
# (cd _build/default/lib && /usr/bin/cc -O2 -fno-strict-aliasing -fwrapv -pthread -D_FILE_OFFSET_BITS=64 -D_FILE_OFFSET_BITS=64 -I/usr/local/include/fuse -g -I /Users/mac1000/.opam/5.0.0/lib/ocaml -I /Users/mac1000/.opam/5.0.0/lib/camlidl -I /Users/mac1000/.opam/5.0.0/lib/ocaml/threads -I /Users/mac1000/.opam/5.0.0/lib/ocaml/unix -o Unix_util_stubs.o -c Unix_util_stubs.c)
# Unix_util_stubs.c:151:3: warning: expression result unused [-Wunused-value]
#   bufv;
#   ^~~~
# 1 warning generated.
# File "lib/dune", line 8, characters 9-28:
# 8 |   (names Fuse_bindings_stubs Fuse_util Unix_util_stubs)
#              ^^^^^^^^^^^^^^^^^^^
# (cd _build/default/lib && /usr/bin/cc -O2 -fno-strict-aliasing -fwrapv -pthread -D_FILE_OFFSET_BITS=64 -D_FILE_OFFSET_BITS=64 -I/usr/local/include/fuse -g -I /Users/mac1000/.opam/5.0.0/lib/ocaml -I /Users/mac1000/.opam/5.0.0/lib/camlidl -I /Users/mac1000/.opam/5.0.0/lib/ocaml/threads -I /Users/mac1000/.opam/5.0.0/lib/ocaml/unix -o Fuse_bindings_stubs.o -c Fuse_bindings_stubs.c)
# Fuse_bindings_stubs.c:698:3: error: implicit declaration of function 'enter_blocking_section' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
#   enter_blocking_section();
#   ^
# Fuse_bindings_stubs.c:698:3: note: did you mean 'caml_enter_blocking_section'?
# /Users/mac1000/.opam/5.0.0/lib/ocaml/caml/signals.h:30:17: note: 'caml_enter_blocking_section' declared here
# CAMLextern void caml_enter_blocking_section (void);
#                 ^
# Fuse_bindings_stubs.c:700:3: error: implicit declaration of function 'leave_blocking_section' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
#   leave_blocking_section();
#   ^
# Fuse_bindings_stubs.c:700:3: note: did you mean 'enter_blocking_section'?
# Fuse_bindings_stubs.c:698:3: note: 'enter_blocking_section' declared here
#   enter_blocking_section();
#   ^
# Fuse_bindings_stubs.c:714:3: error: implicit declaration of function 'enter_blocking_section' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
#   enter_blocking_section();
#   ^
# Fuse_bindings_stubs.c:716:3: error: implicit declaration of function 'leave_blocking_section' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
#   leave_blocking_section();
#   ^
# Fuse_bindings_stubs.c:759:3: error: implicit declaration of function 'enter_blocking_section' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
#   enter_blocking_section();
#   ^
# Fuse_bindings_stubs.c:761:3: error: implicit declaration of function 'leave_blocking_section' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
#   leave_blocking_section();
#   ^
# 6 errors generated.
# (cd _build/default/lib && /usr/bin/cc -O2 -fno-strict-aliasing -fwrapv -pthread -D_FILE_OFFSET_BITS=64 -D_FILE_OFFSET_BITS=64 -I/usr/local/include/fuse -g -I /Users/mac1000/.opam/5.0.0/lib/ocaml -I /Users/mac1000/.opam/5.0.0/lib/camlidl -I /Users/mac1000/.opam/5.0.0/lib/ocaml/threads -I /Users/mac1000/.opam/5.0.0/lib/ocaml/unix -o Fuse_util.o -c Fuse_util.c)
# Fuse_util.c:632:13: warning: add explicit braces to avoid dangling else [-Wdangling-else]
# FOR_ALL_OPS(CALLBACK)
#             ^
# Fuse_util.c:644:15: warning: incompatible function pointer types assigning to 'int (*)(const char *, const char *, const char *, size_t, int, uint32_t)' (aka 'int (*)(const char *, const char *, const char *, unsigned long, int, unsigned int)') from 'int (const char *, const char *, const char *, size_t, int)' (aka 'int (const char *, const char *, const char *, unsigned long, int)') [-Wincompatible-function-pointer-types]
#   FOR_ALL_OPS(SET_OPERATION)
#   ~~~~~~~~~~~~^~~~~~~~~~~~~~
# Fuse_util.c:328:3: note: expanded from macro 'FOR_ALL_OPS'
#   MACRO(setxattr)                               \
#   ^~~~~~~~~~~~~~~
# Fuse_util.c:639:15: note: expanded from macro 'SET_OPERATION'
#     ops.OPNAME=ops_##OPNAME;                        \
#               ^~~~~~~~~~~~~
# Fuse_util.c:644:15: warning: incompatible function pointer types assigning to 'int (*)(const char *, const char *, char *, size_t, uint32_t)' (aka 'int (*)(const char *, const char *, char *, unsigned long, unsigned int)') from 'int (const char *, const char *, char *, size_t)' (aka 'int (const char *, const char *, char *, unsigned long)') [-Wincompatible-function-pointer-types]
#   FOR_ALL_OPS(SET_OPERATION)
#   ~~~~~~~~~~~~^~~~~~~~~~~~~~
# Fuse_util.c:329:3: note: expanded from macro 'FOR_ALL_OPS'
#   MACRO(getxattr)                               \
#   ^~~~~~~~~~~~~~~
# Fuse_util.c:639:15: note: expanded from macro 'SET_OPERATION'
#     ops.OPNAME=ops_##OPNAME;                        \
#               ^~~~~~~~~~~~~
# 3 warnings generated.

bug-reports: "https://github.com/astrada/ocamlfuse/issues"
depends: [
"dune" {>= "3.7"}
"ocaml" {>= "4.02.3"}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See failure above

Suggested change
"ocaml" {>= "4.02.3"}
"ocaml" {>= "4.02.3" & < "5.0"}

Copy link
Contributor Author

@astrada astrada Apr 28, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem seems to be caused by camlidl. It should be solved by this PR: xavierleroy/camlidl#25. When it's released, it should fix the error on macos with ocaml 5.0. The purpose of this new version is indeed supporting ocaml 5.0.

@astrada
Copy link
Contributor Author

astrada commented Apr 28, 2023

On the repo it is marked as pre-release: https://github.com/astrada/ocamlfuse/releases

Fixed. I usually set it as pre-release until I'm sure I don't have to release a hotfix.

@avsm
Copy link
Member

avsm commented May 19, 2023

Just waiting for a camlidl release, so marking this as temporarily blocked. Unless you'd like to mark it as !macos and get it in the repo for Linux, @astrada ?

@astrada
Copy link
Contributor Author

astrada commented May 20, 2023

Just waiting for a camlidl release, so marking this as temporarily blocked. Unless you'd like to mark it as !macos and get it in the repo for Linux, @astrada ?

OK, I pushed an opam file that disables macos

@mseri
Copy link
Member

mseri commented May 24, 2023

Thanks!

@astrada astrada deleted the ocamlfuse branch May 24, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants