Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] irmin project (3.5.1) #22837

Merged
merged 2 commits into from
Jan 10, 2023
Merged

Conversation

metanivek
Copy link
Contributor

@metanivek metanivek commented Jan 4, 2023

Project page: https://github.com/mirage/irmin

CHANGES:

Fixed

@metanivek metanivek changed the title [new release] ppx_irmin, libirmin, irmin, irmin-tezos, irmin-tezos-utils, irmin-test, irmin-pack, irmin-mirage, irmin-mirage-graphql, irmin-mirage-git, irmin-http, irmin-graphql, irmin-git, irmin-fs, irmin-containers, irmin-cli, irmin-chunk and irmin-bench (3.5.1) [new release] irmin project (3.5.1) Jan 4, 2023
@metanivek metanivek force-pushed the release-irmin-3.5.1 branch from d6b8648 to d6faec9 Compare January 5, 2023 14:36
…ils, irmin-test, irmin-pack, irmin-mirage, irmin-mirage-graphql, irmin-mirage-git, irmin-http, irmin-graphql, irmin-git, irmin-fs, irmin-containers, irmin-cli, irmin-chunk and irmin-bench (3.5.1)

CHANGES:

### Fixed

- **irmin-pack**
  - Integrity check of a commit works on stores using the minimal indexing
    strategy. (mirage/irmin#2160, @icristescu)
@metanivek metanivek force-pushed the release-irmin-3.5.1 branch from d6faec9 to f0876a7 Compare January 5, 2023 19:04
@metanivek
Copy link
Contributor Author

I don't think any of the CI failures are related to this release.

@raphael-proust
Copy link
Contributor

The CI errors seem to fall in the following categories:

  • Timeouts (I've restarted those)
  • Network errors when installing system packages (same)
  • ld exists with 1 on the more exotic architectures
  • ca-cert issue on macos protected build env

I don't think those errors should block this PR

@kit-ty-kate
Copy link
Member

  • The macos errors should be restricted at the opam file level (disable the tests on macos)
  • The mtime link failures seem related too. Could you have a look at them?

@metanivek
Copy link
Contributor Author

@kit-ty-kate

I disabled tests for macos with the packages that are failing. CI is running again but these errors should disappear. The libirmin build is also failing macos but I did not remove its availability on that platform. This package does work on macos but unfortunately suffers from this known issue on opam CI: mirage/ca-certs#20.

As for mtime, I can't quite figure this one out. Is this an mtime issue or an irmin one? All the linking failures are happening on "exotic" (as @raphael-proust puts it 😄) architectures, but also all the failures are when building with OCaml 5. I'm happy to adjust something within Irmin but not sure what I would do (if there is indeed anything I can).

Thanks for the reviews @kit-ty-kate and @raphael-proust.

@samoht
Copy link
Member

samoht commented Jan 10, 2023

I don't understand what are the mtime failures. Merging as is as most of the "base" tests pass fine, but happy to take follow fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants