Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new file: packages/acp4/acp4.1.0.1/opam #22767

Merged
merged 8 commits into from
Jan 7, 2023
Merged

new file: packages/acp4/acp4.1.0.1/opam #22767

merged 8 commits into from
Jan 7, 2023

Conversation

UnixJunkie
Copy link
Contributor

No description provided.

@raphael-proust
Copy link
Contributor

There are some build issues. I think the package needs lower bounds on ocaml (>= "4.08") or possibly batterie.

Also, there are some lowerbound errors that seem due to dolog: works with 6.0.0 but not with 1.1. I don't know what the appropriate limit it.

@UnixJunkie
Copy link
Contributor Author

I am fine with those lower bounds, I will reflect them in the opam file upstream, thanks.

mseri
mseri reviewed Jan 3, 2023
View reviewed changes
packages/acp4/acp4.1.0.1/opam Outdated Show resolved Hide resolved
@mseri mseri mentioned this pull request Jan 3, 2023
Merged
@UnixJunkie
Copy link
Contributor Author

Thanks, I will merge the corrections to the opam file upstream.

@UnixJunkie
Copy link
Contributor Author

Still no tool on the horizon to help package maintainers automatically found the lower bounds for their software?
Or there was a shell script from @kit-ty-kate at least? I should find it back and give it a try.

@kit-ty-kate
Copy link
Member

@UnixJunkie I don't remember having a script for that but i've just made a quick posix-shell script here: https://github.com/kit-ty-kate/opam-detect-constraints

It's not the fastest thing nor the most clever but at least it should work

mseri
mseri reviewed Jan 5, 2023
View reviewed changes
packages/acp4/acp4.1.0.1/opam Outdated Show resolved Hide resolved
mseri
mseri reviewed Jan 6, 2023
View reviewed changes
packages/acp4/acp4.1.0.1/opam Outdated Show resolved Hide resolved
@kit-ty-kate kit-ty-kate merged commit 9f576a1 into ocaml:master Jan 7, 2023
@kit-ty-kate
Copy link
Member

Thanks. Could you return the fixes to the opam file upstream?

@UnixJunkie
Copy link
Contributor Author

I will reflect upstream, thanks.

@UnixJunkie UnixJunkie deleted the acp4_101 branch January 9, 2023 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mseri mseri mseri left review comments

Assignees
No one assigned
Labels
consider for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@UnixJunkie @raphael-proust @kit-ty-kate @mseri