Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] opam-monorepo (0.3.5) #22765

Merged

Conversation

Leonidas-from-XIV
Copy link
Contributor

Assemble and manage fully vendored Dune repositories

CHANGES:

Changed

Fixed

CHANGES:

### Changed

- Treat packages with no build commands as if they can be built with dune (tarides/opam-monorepo#355,
  @gridbugs)

### Fixed

- Fix resolving refs of locally pinned repositories (tarides/opam-monorepo#326, tarides/opam-monorepo#332, @hannesm,
  @Leonidas-from-XIV)
- Read the `compiler` flag from OPAM metadata thus classifying more packages
  correctly as base packages (tarides/opam-monorepo#328, @Leonidas-from-XIV)
- Fix bug where dev repo urls ending with a "/" would result in
  `opam monorepo pull` placing package source code directly inside the duniverse
  directory instead of in a subdirectory of the duniverse directory (tarides/opam-monorepo#359,
  @gridbugs)
@raphael-proust
Copy link
Contributor

CI errors:

  • Some revdeps: mirage on 4.14 and 5.0. I don't know if it's related to this PR.
  • Archlinux system package installation errors: should be fixed when updating the base image which should include some new maintainer keys. Not blocking IMO.
  • opensuse system package installation error: I don't know opensuse well enough to tell, but that seems to be a transient network issue or maybe a docker image issue.

@kit-ty-kate
Copy link
Member

The revdeps failures are related. This is because mirage uses opam-monorepo in its (recent) tests

@Leonidas-from-XIV
Copy link
Contributor Author

Looks like the Arch Linux and OpenSUSE tests are unrelated issues.

The mirage failures are indeed unexpected and hint at the fact that the test-suite of opam-monorepo is not exercising the case that mirage is running into because I don't see how the changes between 0.3.4 and 0.3.5 would break it. It's possible something went wrong in this release.

@Leonidas-from-XIV
Copy link
Contributor Author

Leonidas-from-XIV commented Dec 22, 2022

Ok, after investigating the issue I think @kit-ty-kate's solution of restricting the version is correct.

It's not really a bug, rather a conscious change in opam-monorepo.0.3.5 that packages without build instructions are considered "virtual" and thus skipped. Mirage ran into this issue because the dummy packages it tests opam-monorepo against do not contain build stanzas.

I've made a PR to mirage to fix it in the future: mirage/mirage#1383

@Leonidas-from-XIV
Copy link
Contributor Author

The conan failures are due to OCaml 5 rejecting the formatters in the conan test, so I've added a constraint: #22790

@kit-ty-kate
Copy link
Member

Thanks! Sorry for the wait

@kit-ty-kate kit-ty-kate merged commit fb1e066 into ocaml:master Jan 5, 2023
@Leonidas-from-XIV Leonidas-from-XIV deleted the release-opam-monorepo-0.3.5 branch May 2, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants