-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[new release] opam-monorepo (0.3.5) #22765
[new release] opam-monorepo (0.3.5) #22765
Conversation
CHANGES: ### Changed - Treat packages with no build commands as if they can be built with dune (tarides/opam-monorepo#355, @gridbugs) ### Fixed - Fix resolving refs of locally pinned repositories (tarides/opam-monorepo#326, tarides/opam-monorepo#332, @hannesm, @Leonidas-from-XIV) - Read the `compiler` flag from OPAM metadata thus classifying more packages correctly as base packages (tarides/opam-monorepo#328, @Leonidas-from-XIV) - Fix bug where dev repo urls ending with a "/" would result in `opam monorepo pull` placing package source code directly inside the duniverse directory instead of in a subdirectory of the duniverse directory (tarides/opam-monorepo#359, @gridbugs)
CI errors:
|
The revdeps failures are related. This is because mirage uses opam-monorepo in its (recent) tests |
Looks like the Arch Linux and OpenSUSE tests are unrelated issues. The mirage failures are indeed unexpected and hint at the fact that the test-suite of opam-monorepo is not exercising the case that mirage is running into because I don't see how the changes between 0.3.4 and 0.3.5 would break it. It's possible something went wrong in this release. |
Ok, after investigating the issue I think @kit-ty-kate's solution of restricting the version is correct. It's not really a bug, rather a conscious change in I've made a PR to |
The conan failures are due to OCaml 5 rejecting the formatters in the conan test, so I've added a constraint: #22790 |
Thanks! Sorry for the wait |
Assemble and manage fully vendored Dune repositories
CHANGES:
Changed
@gridbugs)
Fixed
@Leonidas-from-XIV)
compiler
flag from OPAM metadata thus classifying more packagescorrectly as base packages (Read package flags from OPAM metadata tarides/opam-monorepo#328, @Leonidas-from-XIV)
opam monorepo pull
placing package source code directly inside the duniversedirectory instead of in a subdirectory of the duniverse directory (Fix bug where dev repo urls ending with a "/" would result in
opam monorepo pull
placing package source code directly inside the duniverse directory instead of in a subdirectory of the duniverse directory tarides/opam-monorepo#359,@gridbugs)