Fix architecture support for OCaml 5.x #21510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flambda, frame-pointers and AFL are native-code compilation options and don't make sense in a bytecode-only switch.
Native compiler requires amd64 or arm64.
|
Thanks! |
This was referenced Jun 11, 2022
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OCaml 5.x is only available in native code for amd64 and arm64; all other configurations are bytecode-only.
ocaml-option-32bittherefore pulls inocaml-option-bytecode-onlyfor 5.xocaml-option-afl,ocaml-option-fpandocaml-option-flambdaare native compiler options, so they should always have conflictedocaml-option-bytecode-onlyocaml-option-fpocaml-option-fpocaml-option-bytecode-onlyif the architecture is not amd64 or arm64opam-depextdoesn't install correctly in a bytecode-only switch (ironically, as it always build the bytecode version of the plugin, even in a full compiler switch). This is addressed in Fix build on bytecode-only systems ocaml-opam/opam-depext#149, but this PR also updates the build instructions for 1.2.1 (as a 1.2.1-1 package). There will be a 1.2.2 release with the upstream fix, at which point we can constrain the older packages away from 5.x, but this fix is critical for the CI base images.