Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Yojson 2 constraints #21475

Merged
merged 35 commits into from
Jun 8, 2022
Merged

Yojson 2 constraints #21475

merged 35 commits into from
Jun 8, 2022

Conversation

Leonidas-from-XIV
Copy link
Contributor

This PR is (collecting) the Yojson 2.0.0 maximum constraints that are being revealed by the revdeps of #21460. I'll try to open PRs to the upstream projects which are affected so future releases will support newer Yojson versions again.

@mseri
Copy link
Member

mseri commented Jun 6, 2022

Thanksa lot!

@Leonidas-from-XIV
Copy link
Contributor Author

@c-cube I know it is archived but it looks like the tarball of cconv.0.2 is messed up. Wonder whether to replace it with the one from the OPAM cache?

@mseri
Copy link
Member

mseri commented Jun 6, 2022

I got it from the opam cache, I'll deal with it separately

mseri added a commit that referenced this pull request Jun 6, 2022
@mseri
cconv-0.2: use tarball from opam source archives
27a6e9f 
Seen on #21475
@mseri mseri mentioned this pull request Jun 6, 2022
Merged
@mseri
Copy link
Member

mseri commented Jun 6, 2022

I think this may be full of lower-bound issues. I suggest not to bother with them now unless there is something trivial to fix. I will try to solve them separately in subsequent PRs

@c-cube
Copy link
Contributor

c-cube commented Jun 6, 2022

@Leonidas-from-XIV I think the opam-repo should be updated to use https://github.com/c-cube/cconv/archive/refs/tags/0.2.tar.gz if it's not in sync.

@mseri
Copy link
Member

mseri commented Jun 6, 2022

The tags are brittler than the archives. I am not sure why the md5 of the archive is changed to be honest, it used to work until recently

Leonidas-from-XIV added a commit to Leonidas-from-XIV/ocaml-graphql-server that referenced this pull request Jun 6, 2022
@Leonidas-from-XIV
Raise minimum rresult version
2154c33 
The code needs at least version 0.2.0 of rresult for `>>=` and it needs
at least 0.3.0 for `rresult` to use the `result` compatibility package
to define a `result` type that is compatible with the stdlib `result`
type.

Discovered via the minimum-version checks of
ocaml/opam-repository#21475
@Leonidas-from-XIV Leonidas-from-XIV mentioned this pull request Jun 6, 2022
Merged
@Leonidas-from-XIV
Copy link
Contributor Author

@mseri Ok, I fixed the whole rat-tail of minimum version failures, but there's some leftover failures like obus.1.1.8 which is failing on… unclear what. Maybe ocamlfind? Maybe oasis? Do you have an idea?

@mseri
Copy link
Member

mseri commented Jun 7, 2022

Thanks a lot. I will have a look at this PR tomorrow and most likely merge it. After that we can try the yojson PR again

@Leonidas-from-XIV
Copy link
Contributor Author

Great, let me know when to rebase and squash all the fixup commits. I let it like this for now so the links to the CI would work.

mseri
mseri approved these changes Jun 8, 2022
View reviewed changes
Copy link
Member

@mseri mseri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks a lot

@Leonidas-from-XIV
Add Yojson constraints to revdeps that fail to build with yojson.2.0.0
8050338
@Leonidas-from-XIV
Fix minimum constraint of json_decoder
ba9fe6e 
It fails with the message that it requires dune 1.1.
@Leonidas-from-XIV
Fix minimum dune constraints on docker-api
9c9e91b
@Leonidas-from-XIV
Fix minimum dune constraint on graphql.0.9.0
bc971b8
@Leonidas-from-XIV
Support for package in alias was added in jbuilder.1.0+beta9
e65a5ca
@Leonidas-from-XIV
CCResult was added in containers.0.16
f358428
@Leonidas-from-XIV
package was added in jbuilder.1.0+beta9
50efd64
@Leonidas-from-XIV
BaseCompat was added in oasis.0.4.7
4a2b9cf
@Leonidas-from-XIV
>>= was added to Rresult in 0.2.0
cccccc3
@Leonidas-from-XIV
Minimum dune version is 1.3
b7191a0
@Leonidas-from-XIV
CCResult.result only exists since 1.5
657dd03
@Leonidas-from-XIV
rresult.0.3.0 is required for a compatible result type
7f65835
@Leonidas-from-XIV
Decoders_util exists since decoders.0.3.0
da93df0
@Leonidas-from-XIV
Containers 2.8 is required for CCResult.result before OCaml 4.08
89c2ce9
@Leonidas-from-XIV
Pbrt_json was added in ocaml-protoc.1.0.0
b683432
@Leonidas-from-XIV
ppx_deriving must be in a version supported by dune
59f68f0 
4.2 apparently uses ocaml-migrate-parsetree so probably works as a
minimum.
@Leonidas-from-XIV
Re.Seq was added in re.1.9.0
d8ffb97
@Leonidas-from-XIV
Mybuild.Version.save requires mybuild.4
1ca1e19 
mybuild does not have a version released 4 on OPAM (it exists as git tag
though) but 5 exists and the solver will pick this.
@Leonidas-from-XIV
String.equal requires extlib.1.7.1
7f900d8
@Leonidas-from-XIV
copy_files was added in jbuilder.1.0+beta14
c36e8ca
@Leonidas-from-XIV
--infer-write-query should be available in Menhir since 2018/05/23
bd4a8e7
@Leonidas-from-XIV
re is not just a test dependency, also used in main code
4dfe22e
@Leonidas-from-XIV
obus requires newer menhir for --infer-write-query
8fc03f0
@Leonidas-from-XIV
field_opt requires decoders.0.2.0
7f85487
@Leonidas-from-XIV
array is only available starting decoders.0.6.0
2cbc76c
@Leonidas-from-XIV
bencode takes Integers as int64 since version 2.0
ba6ccad
@Leonidas-from-XIV
EndianBytes was only added in ocplib-endian.0.6
8267a50
@Leonidas-from-XIV
ppx_deriving.4.2 started using omp so maybe works better with sexp
ed254e1
@Leonidas-from-XIV
ppxfind uses -opaque on ocamlc which is available since 4.04
d7397a6
@Leonidas-from-XIV
Msgpck.pp exists since msgpck.1.3
ec1a13b
@Leonidas-from-XIV
Lwt.bind only returns a promise since lwt.3.0.0
3c4e285
@Leonidas-from-XIV
lwt_log.1.0.0 does not install META files, try newer version
bdacc58
@Leonidas-from-XIV
Option.try_with_join was added in JST v0.14
8eebdd2
@Leonidas-from-XIV
Avoid ocamlbuild.0.9.0 to avoid failing to build C stubs
3615e37
@Leonidas-from-XIV
Lwt_log was moved to separate library in Lwt 4
c3c82a9
@Leonidas-from-XIV
Copy link
Contributor Author

Leonidas-from-XIV commented Jun 8, 2022 •
edited
Loading

Ok, I rebased and squashed the constraint-adding commits into one as well as the respective fixup commits, to the list of commits should be reasonably clean. Only additional change was adding the constraints on the atd 2.8.0 release that happened after this PR was opened.

@mseri mseri merged commit 80d3d94 into ocaml:master Jun 8, 2022
@Leonidas-from-XIV Leonidas-from-XIV deleted the yojson-2-constraints branch June 9, 2022 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mseri mseri mseri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Leonidas-from-XIV @mseri @c-cube