Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[new release] ocaml-lsp-server, lsp and jsonrpc (1.6.1) #18709

Merged
merged 5 commits into from
May 19, 2021
Merged

[new release] ocaml-lsp-server, lsp and jsonrpc (1.6.1) #18709

merged 5 commits into from
May 19, 2021

Conversation

rgrinberg
Copy link
Member

LSP Server for OCaml

CHANGES:

Fixes

  • Switch verbosity from 1 to 0. This is the same default that merlin uses.
    The old value for verbosity (Revert verbosity back to 0 ocaml-lsp#433)

  • Get fresh diagnostics (warning and error messages) on a file save (Send diagnostics on file save ocaml-lsp#438)

    Note: If you want the fresh diagnostics to take into account changes in other
    files, you likely need to rebuild your project. An easy way to get automatic
    rebuilds is to run dune in a watching mode, e.g.,[dune build --watch].

@rgrinberg
[new release] ocaml-lsp-server, lsp and jsonrpc (1.6.1)
df85ca2 
CHANGES:

## Fixes

- Switch `verbosity` from 1 to 0. This is the same default that merlin uses.
  The old value for verbosity (ocaml/ocaml-lsp#433)

- Get fresh diagnostics (warning and error messages) on a file save (ocaml/ocaml-lsp#438)

  Note: If you want the fresh diagnostics to take into account changes in other
  files, you likely need to rebuild your project. An easy way to get automatic
  rebuilds is to run `dune` in a watching mode, e.g.,[dune build --watch].
@kit-ty-kate
Copy link
Member

The build failed with:


#=== ERROR while compiling lsp.1.6.1 ==========================================#
# context              2.0.8 | linux/x86_64 | ocaml-base-compiler.4.08.1 | pinned(https://github.com/ocaml/ocaml-lsp/releases/download/1.6.1/jsonrpc-1.6.1.tbz)
# path                 ~/.opam/4.08/.opam-switch/build/lsp.1.6.1
# command              ~/.opam/opam-init/hooks/sandbox.sh build dune build -p lsp -j 31 @install
# exit-code            1
# env-file             ~/.opam/log/lsp-15-4b1281.env
# output-file          ~/.opam/log/lsp-15-4b1281.out
### output ###
#       ocamlc lsp/src/.lsp.objs/byte/lsp__Import.{cmi,cmo,cmt} (exit 2)
# (cd _build/default && /home/opam/.opam/4.08/bin/ocamlc.opt -w -40 -g -bin-annot -I lsp/src/.lsp.objs/byte -I /home/opam/.opam/4.08/lib/jsonrpc -I /home/opam/.opam/4.08/lib/ocaml/threads -I /home/opam/.opam/4.08/lib/pp -I /home/opam/.opam/4.08/lib/ppx_yojson_conv_lib -I /home/opam/.opam/4.08/lib/uutf -I /home/opam/.opam/4.08/lib/yojson -I vendor/stdune-unstable/.stdune.objs/byte -no-alias-deps -open Lsp__ -o lsp/src/.lsp.objs/byte/lsp__Import.cmo -c -impl lsp/src/import.ml)
# File "lsp/src/import.ml", line 9, characters 10-21:
# 9 |         | Either.Left v -> part (v :: left) right l
#               ^^^^^^^^^^^
# Error: Unbound module Either

@rgrinberg
Copy link
Member Author

rgrinberg commented May 19, 2021 via email

@kit-ty-kate kit-ty-kate merged commit 4fa5869 into ocaml:master May 19, 2021
@kit-ty-kate
Copy link
Member

Thanks! Could you return the fixes upstream?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kit-ty-kate kit-ty-kate kit-ty-kate left review comments

Assignees
No one assigned
Labels
consider for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rgrinberg @kit-ty-kate