[new release] ocamlgraph_gtk and ocamlgraph (2.0.0) #17344

backtracking · 2020-10-02T13:51:46Z

CHANGES:

port to dune and opam 2.0
- ❗ opam package now split into two packages: ocamlgraph and ocamlgraph_gtk
- [WeakTopological] fixed incorrect use of generic hash tables
  (Replace generic hash table by functorial in WeakTopological backtracking/ocamlgraph#99, Tomáš Dacík)
- [Oper] fixed transitive_reduction (Transitive reduction is incorrect backtracking/ocamlgraph#91)
- fix incorrect uses of polymorphic equality (Steffen Smolka, Boris Yakobowski)
- [Coloring] fixed generation of OCamlDoc documentation
  (contributed by Earnestly)
- ❗ [Coloring] functions now fail if the graph is directed
- ❗ [Coloring] now uses a single, global exception [NoColoring]
- [Coloring] new function two_color to 2-color a graph (or fail)
- ❗ [Fixpoint] Take initial labeling of nodes into account (Johannes Kloos)

CHANGES: - port to dune and opam 2.0 - ❗ opam package now split into two packages: ocamlgraph and ocamlgraph_gtk - [WeakTopological] fixed incorrect use of generic hash tables (backtracking/ocamlgraph#99, Tomáš Dacík) - [Oper] fixed transitive_reduction (backtracking/ocamlgraph#91) - fix incorrect uses of polymorphic equality (Steffen Smolka, Boris Yakobowski) - [Coloring] fixed generation of OCamlDoc documentation (contributed by Earnestly) - ❗ [Coloring] functions now fail if the graph is directed - ❗ [Coloring] now uses a single, global exception [NoColoring] - [Coloring] new function two_color to 2-color a graph (or fail) - ❗ [Fixpoint] Take initial labeling of nodes into account (Johannes Kloos)

backtracking · 2020-10-02T13:53:00Z

Please do not merge, even if CI passes. (We still need to check with the Frama-C team is this is fine for them.)

camelus · 2020-10-02T14:44:09Z

Commit: 7d6c312

@backtracking has posted 30 contributions.

☀️ All lint checks passed `7d6c312`

These packages passed lint tests: dose3.5.0.1, llvmgraph.0.2, not-ocamlfind.0.07, ocamlgraph.2.0.0, ocamlgraph_gtk.2.0.0, opam-lib.1.3.1, why3.1.2.1

☀️ Installability check (+2)

new installable packages (2): ocamlgraph.2.0.0 ocamlgraph_gtk.2.0.0

backtracking · 2020-10-02T18:38:12Z

The Travis CI build failed with OCaml 4.09 with the following error:

[ERROR] The compilation of conf-gnomecanvas failed at
        "/usr/local/bin/pkg-config libgnomecanvas-2.0".

Is this something I can do anything about?

mseri · 2020-10-02T22:05:26Z

Do you know if conf-gnomecanvas can be made compatible with freebsd?

kit-ty-kate · 2020-10-02T22:09:25Z

Do you know if conf-gnomecanvas can be made compatible with freebsd?

I just tested locally and there is a libgnomecanvas package. I'll make a separate PR

mseri · 2020-10-05T16:02:43Z

There is only a weird failure on the tests:

#=== ERROR while compiling ocamlgraph.2.0.0 ===================================#
# context              2.0.7 | linux/x86_64 | ocaml-base-compiler.4.08.1 | pinned(https://github.com/backtracking/ocamlgraph/releases/download/2.0.0/ocamlgraph-2.0.0.tbz)
# path                 ~/.opam/4.08/.opam-switch/build/ocamlgraph.2.0.0
# command              ~/.opam/4.08/bin/dune build -p ocamlgraph -j 72 @install @runtest
# exit-code            1
# env-file             ~/.opam/log/ocamlgraph-29-ebe0e0.env
# output-file          ~/.opam/log/ocamlgraph-29-ebe0e0.out
### output ###
# File "examples/dune", line 3, characters 23-31:
# 3 |  (libraries graph unix graphics threads))
#                            ^^^^^^^^
# Error: Library "graphics" not found.
# Hint: try:
#   dune external-lib-deps --missing -p ocamlgraph -j 72 @install @runtest
# test_chaotic: all tests succeeded.
# dot: all tests succeeded.
# test_fixpoint: all tests succeeded.
# strat: all tests succeeded.
# test_wto: all tests succeeded.
# test_johnson: all tests succeeded.
# basic: all tests succeeded.
# test_components: all tests succeeded.
# test_bf: all tests succeeded.
# test_topsort alias tests/runtest
# test topsort: all tests succeeded.
#        check alias tests/runtest
# check: all tests succeeded

Should we add graphics as a with-test dependency? Not sure why it fails only on 4.08. If it is not critical, we can just ignore the failure or disable the tests for that case.

pascutto · 2020-10-05T16:16:24Z

It's not clear to me why this fails; it is already added as a test dependency in 4461cfc.

kit-ty-kate · 2020-10-05T17:35:01Z

I did a bit of digging here and it seems to be because the graphics package does not install any META file itself and instead let ocamlfind do it (but in the case of OCaml 4.08 ocamlfind wasn't needed) :/ This is a bit weird. @dra27 is that expected?

backtracking · 2020-10-06T20:19:22Z

I added a constraint <= "1.8.8" for the 5 packages that did not compile anymore.

dra27

A couple of constraint suggestions. The alternative, notwithstanding an update to the graphics packages, is to add "ocamlfind" {with-test}, but it's a shame to switch to Dune and still actively depend on ocamlfind!

dra27 · 2020-10-07T07:33:59Z

packages/dose3/dose3.5.0.1/opam

@@ -26,7 +26,7 @@ remove: [
 ]
 depends: [
  "ocaml"
-  "ocamlgraph" {>= "1.8.6"}
+  "ocamlgraph" {>= "1.8.6" & <= "1.8.8"}


Wouldn't it be better to allow the possibility of a 1.8.x patch release and make this:

Suggested change

"ocamlgraph" {>= "1.8.6" & <= "1.8.8"}

"ocamlgraph" {>= "1.8.6" & < "2.0.0"}

(and others, if you agree)

dra27 · 2020-10-07T07:46:53Z

packages/ocamlgraph/ocamlgraph.2.0.0/opam

+depends: [
+  "ocaml" {>= "4.03.0"}
+  "stdlib-shims"
+  "dune" {>= "2.0"}


Suggested change

"dune" {>= "2.0"}

"dune" {>= "2.0" & !with-test | >= "2.8"}

This fixes the issue with the graphics package (which at present means ocamlgraph.2.0.0 can't be installed with --with-test on 4.08 and earlier)

dra27 · 2020-10-07T07:47:48Z

packages/ocamlgraph_gtk/ocamlgraph_gtk.2.0.0/opam

+  "lablgtk"
+  "conf-gnomecanvas"
+  "ocamlgraph"
+  "dune" {>= "2.0"}


Suggested change

"dune" {>= "2.0"}

"dune" {>= "2.0" & !with-test | >= "2.8"}

done.

Many thanks @dra27 for all these suggestions. You have to pardon me for my inexperience with dune and opam packaging; I'm relatively new to these things.

No problem at all! The graphics/Dune thing is an unusual corner-case anyway. It's lovely to have ocamlgraph ported to build with Dune (having maintained patches for it in opam for quite a while!)

mseri · 2020-10-07T21:12:09Z

I will wait for the big CI to run, but I think this is now good to merge

mseri · 2020-10-08T14:41:13Z

The CI runs look good. Thank you all very much

backtracking added 2 commits October 2, 2020 17:41

ocamlgraph.2.0.0: added depends graphics with-test

4461cfc

ocamlgraph_gtk.2.0.0: added depends graphics with-test

4cf96a8

kit-ty-kate mentioned this pull request Oct 2, 2020

conf-gnomecanvas: Add support for FreeBSD #17346

Merged

ocamlgraph 2.0.0 requires OCaml >= 4.03.0

9d31def

kit-ty-kate mentioned this pull request Oct 5, 2020

graphics < 4.09: fix META file installation #17358

Closed

dra27 mentioned this pull request Oct 6, 2020

Detect graphics library for OCaml < 4.09 ocaml/dune#3855

Merged

added a constraint 'ocamlgraph <= 1.8.8'

ae0aa32

dra27 reviewed Oct 7, 2020

View reviewed changes

better constraints (suggested by David Allsopp)

7d6c312

mseri added the consider for merge label Oct 7, 2020

mseri merged commit 3072a29 into ocaml:master Oct 8, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[new release] ocamlgraph_gtk and ocamlgraph (2.0.0) #17344

[new release] ocamlgraph_gtk and ocamlgraph (2.0.0) #17344

backtracking commented Oct 2, 2020

backtracking commented Oct 2, 2020

camelus commented Oct 2, 2020 •

edited

Loading

backtracking commented Oct 2, 2020

mseri commented Oct 2, 2020

kit-ty-kate commented Oct 2, 2020 •

edited

Loading

mseri commented Oct 5, 2020

pascutto commented Oct 5, 2020

kit-ty-kate commented Oct 5, 2020

backtracking commented Oct 6, 2020

dra27 left a comment

dra27 Oct 7, 2020

backtracking Oct 7, 2020

dra27 Oct 7, 2020

backtracking Oct 7, 2020

dra27 Oct 7, 2020

backtracking Oct 7, 2020

dra27 Oct 7, 2020

mseri commented Oct 7, 2020

mseri commented Oct 8, 2020

	"ocamlgraph" {>= "1.8.6" & <= "1.8.8"}
	"ocamlgraph" {>= "1.8.6" & < "2.0.0"}

[new release] ocamlgraph_gtk and ocamlgraph (2.0.0) #17344

[new release] ocamlgraph_gtk and ocamlgraph (2.0.0) #17344

Conversation

backtracking commented Oct 2, 2020

backtracking commented Oct 2, 2020

camelus commented Oct 2, 2020 • edited Loading

☀️ All lint checks passed 7d6c312

☀️ Installability check (+2)

backtracking commented Oct 2, 2020

mseri commented Oct 2, 2020

kit-ty-kate commented Oct 2, 2020 • edited Loading

mseri commented Oct 5, 2020

pascutto commented Oct 5, 2020

kit-ty-kate commented Oct 5, 2020

backtracking commented Oct 6, 2020

dra27 left a comment

Choose a reason for hiding this comment

dra27 Oct 7, 2020

Choose a reason for hiding this comment

backtracking Oct 7, 2020

Choose a reason for hiding this comment

dra27 Oct 7, 2020

Choose a reason for hiding this comment

backtracking Oct 7, 2020

Choose a reason for hiding this comment

dra27 Oct 7, 2020

Choose a reason for hiding this comment

backtracking Oct 7, 2020

Choose a reason for hiding this comment

dra27 Oct 7, 2020

Choose a reason for hiding this comment

mseri commented Oct 7, 2020

mseri commented Oct 8, 2020

camelus commented Oct 2, 2020 •

edited

Loading

☀️ All lint checks passed `7d6c312`

kit-ty-kate commented Oct 2, 2020 •

edited

Loading