Package bastet_async.0.1.0 #16082
Package bastet_async.0.1.0 #16082
Conversation
Risto-Stevcev
force-pushed
the
opam-publish-bastet_async.0.1.0
branch
2 times, most recently
from
4320edb to
1fc07d0
Compare
| "merlin" {>= "3.3.3" & with-test} | ||
| "ocamlformat" {>= "0.13.0" & with-test} |
There was a problem hiding this comment.
I apparently missed that in your previous PRs for bastet but I'm a bit surprised to see merlin and ocamlformat as test dependencies. I'm curious, how do you use them during tests?
There was a problem hiding this comment.
It's just a convenience because I recreate the local switch to test before deploying
There was a problem hiding this comment.
This not really the purpose of test dependencies, also this contribute to clogging up our CI. Would it be possible to have a separate opam file for that purpose if you really need it? See #15964 (comment) for a similar answer I gave a few weeks ago.
There was a problem hiding this comment.
Yeah, I think it might be better keeping this in the Makefile anyway -- I still have to run multiple commands with this in place anyway, but if I put it in make I can set it up to do all of this stuff in one command.
Risto-Stevcev
force-pushed
the
opam-publish-bastet_async.0.1.0
branch
3 times, most recently
from
a9c8214 to
2c222c4
Compare
|
Commit: 2c222c4 @Risto-Stevcev has posted 9 contributions. ☀️ All lint checks passed 2c222c4
☀️ Installability check (+1)
|
|
Thanks! |
bastet_async.0.1.0Async implementations for bastet
🐫 Pull-request generated by opam-publish v2.0.2