Add piqilib-0.6.15 #14947
Merged
Add piqilib-0.6.15 #14947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☀️ All lint checks passed b5349b1
☀️ Installability check (+1)
|
|
should be good to go. Can you merge this? the test failure on osx is due to missing CXXFLAGS='-std=c++14' and only triggered when protobuf is installed. I'll disable running protobuf-related tests by default in future versions so that opam doesn't stumble on problems like this |
mseri
reviewed
Sep 28, 2019
|
Before I merge can you check if the failure on Travis osx test is expected? |
|
@mseri yes, the test failure is expected. Ok to merge with it. See my first comment in this pull request for details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.