Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce conflicts between base64 >=3.0.0 and extlib, both define the base64 module #13552

Merged
merged 1 commit into from
Feb 28, 2019

Conversation

hannesm
Copy link
Member

@hannesm hannesm commented Feb 28, 2019

No description provided.

@hannesm hannesm mentioned this pull request Feb 28, 2019
@hannesm
Copy link
Member Author

hannesm commented Feb 28, 2019

(upstreamed at mirage/ocaml-base64#29)

@hannesm hannesm mentioned this pull request Feb 28, 2019
@camelus
Copy link
Contributor

camelus commented Feb 28, 2019

☀️ All lint checks passed 634a997
  • These packages passed lint tests: base64.3.0.0, base64.3.1.0

☀️ Installability check (10547 → 10547)

@mseri
Copy link
Member

mseri commented Feb 28, 2019

Thanks

@mseri mseri merged commit 7f31a76 into ocaml:master Feb 28, 2019
@hannesm hannesm deleted the base64-extlib-conflict branch February 28, 2019 16:22
@jvillard
Copy link
Contributor

jvillard commented Mar 1, 2019

This breaks infer which requires extlib and base64. Extlib is a transitive dependency of javalib.2.3.6 which infer uses, and infer itself uses base64.3.1.0. Would it be possible to revert this change?

@avsm
Copy link
Member

avsm commented Mar 1, 2019

hm yes, this should be reverted. in the case of module namespace clashes, the conflict should be at the point of linking, not the point of compiling the modules involved.

@dinosaure
Copy link
Contributor

About the last version of infer, they didn't use extlib anymore and a patch was send to update OPAM file.

@hannesm
Copy link
Member Author

hannesm commented Mar 2, 2019

@dinosaure maybe @avsm and/or @jvillard can explain this in more detail. from @jvillard comment:

Extlib is a transitive dependency of javalib.2.3.6 which infer uses, and infer itself uses base64.3.1.0

@dinosaure
Copy link
Contributor

Ah, I see ... too many base64 impl.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants