Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete bleeding edge 4.08 compilers as they might be selected by default #12646

Merged
merged 2 commits into from
Sep 18, 2018

Conversation

avsm
Copy link
Member

@avsm avsm commented Sep 18, 2018

temporary solution for ocaml/opam#3510

these bleeding edge compilers will move into a new remote so they
are still accessible to advanced users, but this PR just removes
them for now as it is opam 2.0.0 release day :)

temporary solution for ocaml/opam#3510

these bleeding edge compilers will move into a new remote so they
are still accessible to advanced users, but this PR just removes
them for now as it is opam 2.0.0 release day :)

Signed-off-by: Anil Madhavapeddy <[email protected]>
@camelus
Copy link
Contributor

camelus commented Sep 18, 2018

☀️ No new or changed opam files 4696f70

☀️ Installability check (9657 → 9650)
  • removed installable packages (7): ocaml.4.08.0 ocaml-variants.4.08.0+trunk ocaml-variants.4.08.0+trunk+afl
    ocaml-variants.4.08.0+trunk+default-unsafe-string ocaml-variants.4.08.0+trunk+flambda ocaml-variants.4.08.0+trunk+fp
    ocaml-variants.4.08.0+trunk+fp+flambda

@mseri
Copy link
Member

mseri commented Sep 18, 2018

Let's merge then. Will you need to remove the other +fature variants for older compilers as well before the merge?

@mseri
Copy link
Member

mseri commented Sep 18, 2018

Also, do you need to remove https://github.com/ocaml/opam-repository/tree/2.0.0/packages/ocaml/ocaml.4.08.0 (and ocaml-base-compiler.4.08.0* and ocaml-system-4.08.0* EDIT: those are not there) now that there is no more an ocaml-variant for ocaml 4.08.0?

@avsm
Copy link
Member Author

avsm commented Sep 18, 2018

Yes, thanks for checking! I'm just about to give a talk but can push in an hour or so (or feel free to push to my branch if you get a chance!)

Part of the temporary solution for ocaml/opam#3510

these bleeding edge compilers will move into a new remote so they
are still accessible to advanced users, but this PR just removes
them for now as it is opam 2.0.0 release day :)

Signed-off-by: Marcello Seri <[email protected]>
@mseri
Copy link
Member

mseri commented Sep 18, 2018

Done. I'll double check with camelus and if it's ok merge

@mseri mseri merged commit 463ac6b into ocaml:2.0.0 Sep 18, 2018
@avsm avsm deleted the delete-bleeding-edge-compilers branch September 18, 2018 10:55
@avsm
Copy link
Member Author

avsm commented Sep 18, 2018

thanks @mseri !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants