Skip to content

Commit

Permalink
Maximum constraint on merlin and calculon
Browse files Browse the repository at this point in the history
Leonidas-from-XIV committed Jun 9, 2022
1 parent 013f6ae commit 63cbf66
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion packages/calculon/calculon.0.5/opam
Original file line number Diff line number Diff line change
@@ -16,7 +16,7 @@ depends: [
"irc-client" { >= "0.6.0" & < "0.7.0" }
"irc-client-lwt"
"irc-client-lwt-ssl"
"yojson" {>= "1.4.1"}
"yojson" {>= "1.4.1" & < "2.0.0"}
"containers" { >= "1.2" & < "3.0" }
"ISO8601"
"stringext"
2 changes: 1 addition & 1 deletion packages/merlin/merlin.4.5-414/opam
Original file line number Diff line number Diff line change
@@ -14,7 +14,7 @@ depends: [
"ocaml" {>= "4.14" & < "4.15"}
"dune" {>= "2.9.0"}
"dot-merlin-reader" {>= "4.2"}
"yojson" {>= "1.6.0"}
"yojson" {>= "1.6.0" & < "2.0.0"}
"conf-jq" {with-test}
"csexp" {>= "1.5.1"}
"menhir" {dev}

3 comments on commit 63cbf66

@oemmerson
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have Merlin 4.5-413 installed in a switch and it fails rebuilding when upgrading Yojson to 2.0.0.

#=== ERROR while compiling merlin.4.5-413 =====================================#                                                                               [119/562]
# context     2.1.2 | linux/x86_64 | ocaml-base-compiler.4.13.1 | https://opam.ocaml.org/#5fe6dfc3
# path        ~/programming/ocaml/misc/_opam/.opam-switch/build/merlin.4.5-413    
# command     ~/.opam/opam-init/hooks/sandbox.sh build dune build -p merlin -j 4    
# exit-code   1                                                                     
# env-file    ~/.opam/log/merlin-66256-8ae0e7.env
# output-file ~/.opam/log/merlin-66256-8ae0e7.out                                   
### output ###                                                                      
# (cd _build/default && /home/owen/programming/ocaml/misc/_opam/bin/ocamlopt.opt -open Ocaml_utils -open Ocaml_parsing -open Ocaml_typing -open Merlin_utils -open Mer
lin_analysis -g -I src/frontend/ocamlmerlin/.ocamlmerlin_server.eobjs/byte -I src/frontend/ocamlmerlin/.ocamlmerlin_server.eobjs/native -I /home/owen/programming/ocaml/
misc/_opam/lib/yojson -I src/analysis/.merlin_analysis.objs[...]                  
# File "src/frontend/ocamlmerlin/old/old_IO.ml", line 317, characters 16-39:        
# 317 |   let input   = Json.stream_from_lexbuf (Json.init_lexer ()) lexbuf in
#                       ^^^^^^^^^^^^^^^^^^^^^^^                                     
# Error: Unbound value Json.stream_from_lexbuf
                                                                                    
                                                                                    
                                                                                    
<><> Error report <><><><><><><><><><><><><><><><><><><><><><><><><><><><><><><>
┌─ The following actions failed                                                                                                                                         
│ λ build merlin 4.5-413                                                            
└─                                                                                  
┌─ The following changes have been performed                                                                                                                            
│ ⊘ remove    merlin                 4.5-413                                        
│ ↻ recompile async_js               v0.15.0                                        
│ ↻ recompile async_rpc_websocket    v0.15.0
│ ↻ recompile bonsai                 v0.15.0
│ ↻ recompile cohttp-async           5.0.0                                          
│ ↻ recompile cohttp_async_websocket v0.15.0                                        
│ ↻ recompile conduit                5.1.0                                          
│ ↻ recompile conduit-async          5.1.0                                          
│ ↻ recompile dot-merlin-reader      4.2                                            
│ ↻ recompile incr_dom               v0.15.0
│ ↻ recompile js_of_ocaml            3.11.0                                         
│ ↻ recompile js_of_ocaml-compiler   3.11.0                                         
│ ↻ recompile js_of_ocaml-lwt        3.11.0                                         
│ ↻ recompile js_of_ocaml-ppx        3.11.0      
│ ↻ recompile logs                   0.7.0                                          
│ ↻ recompile ocaml-lsp-server       1.10.5                                         
│ ↻ recompile ppx_css                v0.15.0
│ ↻ recompile ppx_yojson_conv_lib    v0.15.0
│ ↻ recompile virtual_dom            v0.15.0
│ ↗ upgrade   yojson                 1.7.0 to 2.0.0

Should I make a pull request for packages/merlin/merlin.4.5-413/opam as you did for this version?

@Leonidas-from-XIV
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think that would be reasonable. Probably a lot of Merlin versions are affected, I am somewhat surprised that they haven't showed up in the CI revdep build.

@mseri
Copy link
Member

@mseri mseri commented on 63cbf66 Jun 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the ci tests revdeps only with 4.14, which many packages do not support. Please send the PR… I think there will be more to come

Please sign in to comment.