Merlin config handling #697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgrinberg
force-pushed
the
ps/rr/refactor__merlin_config_handling
branch
3 times, most recently
from
b26845e to
25808fe
Compare
rgrinberg
force-pushed
the
ps/rr/refactor__merlin_config_handling
branch
from
25808fe to
515f956
Compare
|
I will get to review this tomorrow. Sorry for the wait |
ulugbekna
approved these changes
May 11, 2022
rgrinberg
force-pushed
the
ps/rr/refactor__merlin_config_handling
branch
from
515f956 to
e273ea0
Compare
everything that handles the configuration data type should live in a submodule ps-id: 04F23C4C-6FC9-432F-BEE5-EB98B9FC99A6
rgrinberg
force-pushed
the
ps/rr/refactor__merlin_config_handling
branch
from
e273ea0 to
7c346fc
Compare
rgrinberg
added a commit
to rgrinberg/opam-repository
that referenced
this pull request
May 12, 2022
CHANGES: - Fix process termination. Once the lsp server is stepped, the process will gracefully terminate (ocaml/ocaml-lsp#697, fixes ocaml/ocaml-lsp#694) - Forward stderr from dune's merlin configuration to the lsp server's stderr (ocaml/ocaml-lsp#697)
|
Thank you! I can confirm that pinning to ocaml-lsp on this commit fixes the #694 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first few commits are just general cleanup and refactoring. The remaining commits, introduce reference counting for processes ran by lsp to get the merlin config.
@anuragsoni once this this ready, it should fix #694