Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable jump code action by default #1411

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

voodoos
Copy link
Collaborator

@voodoos voodoos commented Dec 2, 2024

In some cases these can make the codeAction request slow (>2s).

In some cases these can make the codeAction request slow (>2s).
@coveralls
Copy link

coveralls commented Dec 2, 2024

Pull Request Test Coverage Report for Build 4635

Details

  • 1 of 2 (50.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.004%) to 22.136%

Changes Missing Coverage Covered Lines Changed/Added Lines %
ocaml-lsp-server/src/code_actions.ml 1 2 50.0%
Totals Coverage Status
Change from base Build 4629: 0.004%
Covered Lines: 5633
Relevant Lines: 25447

💛 - Coveralls

@voodoos voodoos merged commit 53fd4e0 into ocaml:master Dec 2, 2024
6 checks passed
voodoos added a commit to voodoos/opam-repository that referenced this pull request Dec 2, 2024
CHANGES:

## Fixes

- Deactivate the `jump` code actions by default. Clients can enable them with
  the `merlinJumpCodeActions` configuration option. Alternatively a custom
  request is provided for ad hoc use of the feature. (ocaml/ocaml-lsp#1411)
voodoos added a commit to voodoos/opam-repository that referenced this pull request Dec 2, 2024
CHANGES:

## Fixes

- Deactivate the `jump` code actions by default. Clients can enable them with
  the `merlinJumpCodeActions` configuration option. Alternatively a custom
  request is provided for ad hoc use of the feature. (ocaml/ocaml-lsp#1411)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants