Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use sigterm instead of sigkill/sigint #1343

Merged
merged 1 commit into from
Jul 13, 2024

Conversation

rgrinberg
Copy link
Member

Signed-off-by: Rudi Grinberg [email protected]

@coveralls
Copy link

coveralls commented Jul 13, 2024

Pull Request Test Coverage Report for Build 4438

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 21.747%

Changes Missing Coverage Covered Lines Changed/Added Lines %
ocaml-lsp-server/src/ocamlformat.ml 0 1 0.0%
Totals Coverage Status
Change from base Build 4434: 0.0%
Covered Lines: 5526
Relevant Lines: 25410

💛 - Coveralls

Signed-off-by: Rudi Grinberg <[email protected]>

<!-- ps-id: 46f9a999-c9d1-4d96-8b1e-833c5c10e940 -->
@rgrinberg rgrinberg force-pushed the ps/rr/fix__use_sigterm_instead_of_sigkill_sigint branch from bf2da6d to 2f647f1 Compare July 13, 2024 23:26
@rgrinberg rgrinberg merged commit 86b48e5 into master Jul 13, 2024
8 checks passed
voodoos added a commit to voodoos/opam-repository that referenced this pull request Jul 30, 2024
CHANGES:

## Features

- Add custom [`ocamllsp/getDocumentation`](/ocaml-lsp-server/docs/ocamllsp/getDocumentation-spec.md) request (ocaml/ocaml-lsp#1336)
- Add support for OCaml 5.2 (ocaml/ocaml-lsp#1233)

## Fixes

- Kill unnecessary ocamlformat processes with sigterm rather than sigint or
  sigkill (ocaml/ocaml-lsp#1343)
voodoos added a commit to voodoos/opam-repository that referenced this pull request Jul 30, 2024
CHANGES:

## Features

- Add custom [`ocamllsp/getDocumentation`](/ocaml-lsp-server/docs/ocamllsp/getDocumentation-spec.md) request (ocaml/ocaml-lsp#1336)
- Add support for OCaml 5.2 (ocaml/ocaml-lsp#1233)

## Fixes

- Kill unnecessary ocamlformat processes with sigterm rather than sigint or
  sigkill (ocaml/ocaml-lsp#1343)
avsm pushed a commit to avsm/opam-repository that referenced this pull request Sep 5, 2024
CHANGES:

## Features

- Add custom [`ocamllsp/getDocumentation`](/ocaml-lsp-server/docs/ocamllsp/getDocumentation-spec.md) request (ocaml/ocaml-lsp#1336)
- Add support for OCaml 5.2 (ocaml/ocaml-lsp#1233)

## Fixes

- Kill unnecessary ocamlformat processes with sigterm rather than sigint or
  sigkill (ocaml/ocaml-lsp#1343)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants