Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatibility with OCaml 5.1 #1150

Merged
merged 9 commits into from
Jun 19, 2023
Merged

Compatibility with OCaml 5.1 #1150

merged 9 commits into from
Jun 19, 2023

Conversation

voodoos
Copy link
Collaborator

@voodoos voodoos commented Jun 19, 2023

This PR aims to make master compatible with OCaml 4.14, 5.0 and 5.1.
Not sure if there will be differences in tests however.

See ocaml/opam-repository#23950 for more context.

@voodoos
Copy link
Collaborator Author

voodoos commented Jun 19, 2023 •
edited
Loading

Is there no ocaml-ci for ocaml-lsp ? It is useful to test on all supported ocaml versions.

edit: I added 5.0 and 5.1 to the matrix, but that makes for a lot of jobs, we might want to restrain some versions of ocaml to only one system / and build-only.

@rgrinberg rgrinberg added this to the 1.16.1 milestone Jun 19, 2023
@rgrinberg
Copy link
Member

edit: I added 5.0 and 5.1 to the matrix, but that makes for a lot of jobs, we might want to restrain some versions of ocaml to only one system / and build-only.

How about we only test 5.0 on Linux

@voodoos
Copy link
Collaborator Author

voodoos commented Jun 19, 2023

So in the end:

  • Tests are run only against the 4.14 version (output is different between versions due to changes in error messages)
  • Build for 5.0 and 5.1 is performed only on ubuntu and works
  • Windows is broken, but that seems independent to these changes...

@rgrinberg
Copy link
Member

Is there no ocaml-ci for ocaml-lsp ? It is useful to test on all supported ocaml versions.

Nope. If there's something you need me to do set it up let me know.

@rgrinberg rgrinberg merged commit c28f560 into ocaml:master Jun 19, 2023
@rgrinberg rgrinberg mentioned this pull request Jun 20, 2023
Merged
rgrinberg added a commit to rgrinberg/opam-repository that referenced this pull request Jun 20, 2023
@rgrinberg
[new release] ocaml-lsp-server, lsp and jsonrpc (1.16.1)
8baf9f1 
CHANGES:

## Fixes

- Support building with OCaml 5.0 and 5.1 (ocaml/ocaml-lsp#1150)
@smorimoto
Copy link
Member

I encountered a crash loop when using lsp with 5.1, any ideas?

@voodoos
Copy link
Collaborator Author

voodoos commented Sep 25, 2023 •
edited
Loading

Do you have any log or reproduction ? We need more information to start investigate.

(Also when you have it's probably bet to open the issue on Merlin directly since it's the most likely culprit.)

voodoos added a commit to voodoos/ocaml-lsp that referenced this pull request Nov 28, 2024
@voodoos
Revert "Compatibility with OCaml 5.1 (ocaml#1150)"
0282bd3 
This reverts commit c28f560.
voodoos added a commit to voodoos/ocaml-lsp that referenced this pull request Nov 29, 2024
@voodoos
Revert "Compatibility with OCaml 5.1 (ocaml#1150)"
00a613d 
This reverts commit c28f560.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.16.1
Development

Successfully merging this pull request may close these issues.
3 participants
@voodoos @rgrinberg @smorimoto