fix: ocamlformat-rpc initialization

[rgrinberg]

if [get_process] is alled concurrently, the ivar might be filled twice.

Fixes #1115

Signed-off-by: Rudi Grinberg [email protected]

[coveralls]

Pull Request Test Coverage Report for Build 3842

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

• For more information on this, see Tracking coverage changes with pull request builds.
• To avoid this issue with future PRs, see these Recommended CI Configurations.
• For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

• 4 of 5 (80.0%) changed or added relevant lines in 1 file are covered.
• 1 unchanged line in 1 file lost coverage.
• Overall coverage decreased (-0.004%) to 17.349%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
ocaml-lsp-server/src/ocamlformat_rpc.ml	4	5	80.0%

Files with Coverage Reduction	New Missed Lines	%
ocaml-lsp-server/src/import.ml	1	35.9%

Totals
Change from base Build 3838:	-0.004%
Covered Lines:	4072
Relevant Lines:	23471

---

💛 - Coveralls

[mariusdkm]

I'm getting this error when trying to build this PR, using opam reinstall ocaml-lsp-server --working-dir --update-invariant. (after I pinned the git repo locally)
I'm using --update-invariant, because otherwise I will get this error:

  * No agreement on the version of ocaml:
    - (invariant) → ocaml-base-compiler = 5.0.0 → ocaml = 5.0.0
    - ocaml-lsp-server >= 1.15.1-5.0 → ocaml < 4.15
    You can temporarily relax the switch invariant with `--update-invariant'

<><> Processing actions <><><><><><><><><><><><><><><><><><><><><><><><><><>  🐫 
[ERROR] The compilation of ocaml-lsp-server.1.15.1-5.0 failed at "dune build -j 7 ocaml-lsp-server.install --release".

#=== ERROR while compiling ocaml-lsp-server.1.15.1-5.0 ========================#
# context     2.1.3 | macos/arm64 | ocaml-base-compiler.4.14.1 | pinned(git+file:///Users/myuser/Downloads/ocaml-lsp#ps/rr/fix__ocamlformat_rpc_initialization#95cb5643)
# path        ~/.opam/5.0.0/.opam-switch/build/ocaml-lsp-server.1.15.1-5.0
# command     ~/.opam/opam-init/hooks/sandbox.sh build dune build -j 7 ocaml-lsp-server.install --release
# exit-code   1
# env-file    ~/.opam/log/ocaml-lsp-server-71853-4e0fa8.env
# output-file ~/.opam/log/ocaml-lsp-server-71853-4e0fa8.out
### output ###
# [...]
# submodules/lev/lev/vendor/ev.c:5275:14: warning: left operand of comma operator has no effect [-Wunused-value]
#     assert (("libev: loop to be embedded is not embeddable", backend & ev_embeddable_backends ()));
#              ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
# /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/assert.h:99:25: note: expanded from macro 'assert'
#     (__builtin_expect(!(e), 0) ? __assert_rtn(__func__, __ASSERT_FILE_NAME, __LINE__, #e) : (void)0)
#                         ^
# 32 warnings generated.
# (cd _build/default && /Users/myuser/.opam/5.0.0/bin/ocamlopt.opt -w -40 -alert -unstable -g -I ocaml-lsp-server/src/.ocaml_lsp_server.objs/byte -I ocaml-lsp-server/src/.ocaml_lsp_server.objs/native -I /Users/myuser/.opam/5.0.0/lib/chrome-trace -I /Users/myuser/.opam/5.0.0/lib/csexp -I /Users/myuser/.opam/5.0.0/lib/dune-build-info -I /Use[...]
# File "ocaml-lsp-server/src/merlin_config.ml", line 221, characters 2-26:
# 221 |   Merlin_dot_protocol.Make
#         ^^^^^^^^^^^^^^^^^^^^^^^^
# Error: Unbound module Merlin_dot_protocol.Make

[rgrinberg]

I think it's because this repo is using a submodule. I don't know how to make opam pull the submodule as well unfortunately.

[mariusdkm]

Oh, I didn't notice the submodule. I just ran git submodule update --init --recursive and then I had to pin it again and then everything compiled.
So far the lsp didn't crash anymore.
Thanks!
(now I can finally do my functional programming exercises I'm supposed to be doing in ocaml)