remove duneContexts, handled in vscode-ocaml

ocaml · May 3, 2024 · 9ada875 · 9ada875
1 parent afbf1ba
commit 9ada875
Show file tree

Hide file tree

Showing 6 changed files with 2 additions and 90 deletions.
diff --git a/CHANGES.md b/CHANGES.md
@@ -8,7 +8,7 @@
 
 - Support folding of `ifthenelse` expressions (#1031)
 
-- Add `duneContexts` method and `--context` flag (#1238)
+- Add `--context` flag (#1238)
 
 ## Fixes
 

diff --git a/ocaml-lsp-server/docs/ocamllsp/duneContexts-spec.md b/ocaml-lsp-server/docs/ocamllsp/duneContexts-spec.md
diff --git a/ocaml-lsp-server/src/custom_requests/req_dune_contexts.ml b/ocaml-lsp-server/src/custom_requests/req_dune_contexts.ml
diff --git a/ocaml-lsp-server/src/custom_requests/req_dune_contexts.mli b/ocaml-lsp-server/src/custom_requests/req_dune_contexts.mli
diff --git a/ocaml-lsp-server/src/ocaml_lsp_server.ml b/ocaml-lsp-server/src/ocaml_lsp_server.ml
@@ -98,7 +98,6 @@ let initialize_info (client_capabilities : ClientCapabilities.t) :
               ; Req_wrapping_ast_node.capability
               ; Dune.view_promotion_capability
               ; Req_hover_extended.capability
-              ; Req_dune_contexts.capability
               ] )
         ]
     in
@@ -511,10 +510,6 @@ let on_request :
         , Semantic_highlighting.Debug.on_request_full )
       ; ( Req_hover_extended.meth
         , fun ~params _ -> Req_hover_extended.on_request ~params rpc )
-      ; ( Req_dune_contexts.meth
-        , fun ~params:_ _ ->
-            Fiber.of_thunk (fun () ->
-                Fiber.return (Req_dune_contexts.on_request ())) )
       ]
       |> List.assoc_opt meth
     with

diff --git a/ocaml-lsp-server/test/e2e-new/start_stop.ml b/ocaml-lsp-server/test/e2e-new/start_stop.ml
@@ -90,8 +90,7 @@ let%expect_test "start/stop" =
               "handleTypedHoles": true,
               "handleWrappingAstNode": true,
               "diagnostic_promotions": true,
-              "handleHoverExtended": true,
-              "handleDuneContexts": true
+              "handleHoverExtended": true
             }
           },
           "foldingRangeProvider": true,