INSTALL_LOCAL option: allowing a specific compiler to be tested as a "system" compiler #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dra27
added a commit
to dra27/opam-repository
that referenced
this pull request
Jan 18, 2018
Until ocaml/ocaml-ci-scripts#202 is merged, then this commit can be blown away.
dra27
force-pushed
the
test-system-switches
branch
from
169bb3a to
f8b31df
Compare
|
lgtm, but does need an entry in the README.travis about the new variable. thanks! |
Previously, OPAM_SWITCH was given a default value of system which was then subsequently ignored in all the branches. OPAM_SWITCH is now only set if it wasn't previously given which allows, for example, testing OCaml release candidates by specifying OCAML_VERSION=4.07 OPAM_SWITCH=4.07.0+beta1 as part of a test matrix. Resolves ocaml#175
Adding INSTALL_LOCAL=1 for Linux builds will build the compiler and install it in /usr/local for use in a system opam switch.
dra27
force-pushed
the
test-system-switches
branch
from
f8b31df to
600bcd7
Compare
|
'tis done - I also took the opportunity to s/OPAM/opam/g - my new paragraphs are the very obvious green lumps in the diff, the other changes in README-travis.md are just that transformation. |
|
Hooray - it's finally passed CI 🙂 |
|
Merging this now while I'll be around to see whether it breaks anything. Thanks @dra27 ! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR achieves the dual purpose of addressing my request in #175 which will allow, for example, the first beta of OCaml 4.07.0 to be tested in a Travis matrix and also builds on this tweak to provide a new option
INSTALL_LOCALfor the Linux hosts which instead of switching to a particular OCaml version will instead compile it locally, install it to/usr/localand then have opam use that compiler as asystemswitch.The primary motivation of this is opam-repository continuous testing of system installation on a platform with "normal" security (i.e. not macOS).
The support can probably be extended to osx hosts, but it's not necessary for what I'm after as brew tracks latest OCaml already and the inability to virtualise macOS makes it more of a pain to test than even I am willing to endure...