-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(pkg): dune pkg outdated #8773
feature(pkg): dune pkg outdated #8773
Conversation
10cd623
to
de6abb3
Compare
de6abb3
to
754f77c
Compare
I like how the output can separate transitive vs. immediate dependencies, but I don't think this is something users will find obvious. So how about making the normal mode explain this. E.g.
|
754f77c
to
e9c0d97
Compare
@rgrinberg I've refactored the error handling to use result instead rather than messing around with fibers. At the end I use I've also added support for the I'll see what I can do for adding more information about immediate vs transitive deps in the message and also some counting. |
f345681
to
3f741e3
Compare
I've merged the errors into a single error message, however they are still separate errors per context. See the test for how this looks in practice. |
3f741e3
to
42df514
Compare
I've pushed a change that gives informative statuses based on the information present. Notably there is now a module This also lets us test the messages extensively, so I have gone ahead and done that and enumerated all the combinations of 4 packages both transitive and immediate to test how the message ought to change. I haven't yet settles on the forms of the status, notably I didn't incorporate @rgrinberg's suggestion of counts in the statuses yet. I also have some cleanup to do in the cram test since there is some redundant information with the context. I will iterate on this tomorrow. |
8b4baa3
to
1d1dcd6
Compare
1d1dcd6
to
5814c0d
Compare
81cea41
to
806c8c5
Compare
94a98a3
to
baf0658
Compare
All the pretty printing code should be moved from |
@rgrinberg Can I propose splitting up |
How about you just add your own command as |
@rgrinberg Sorry, I didn't mean splitting all the other commands, I just meant outdated. |
f6e8423
to
ae5824b
Compare
f256c36
to
9691b00
Compare
We add a `dune pkg outdated` package that will display outdated package dependencies with respect to the condigured opam repositories. It comes with a --transitive flag that shows all outdated transitive deps. Signed-off-by: Ali Caglayan <[email protected]>
9691b00
to
25c360e
Compare
@rgrinberg I've removed the changes to the dune files like you suggested. |
We add a
dune pkg outdated
package that will display outdated package dependencies with respect to the configured opam repositories.It comes with a --transitive flag that shows all outdated transitive deps.
Screenshots