Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(melange): incorrect path when public lib depends on private lib #7652

Merged
merged 1 commit into from
May 4, 2023
Merged

test(melange): incorrect path when public lib depends on private lib #7652

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 57 additions & 0 deletions test/blackbox-tests/test-cases/melange/private-lib-dep.t
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,57 @@
Melange public library depends on private library

$ cat > dune-project <<EOF
> (lang dune 3.8)
> (package (name foo))
> (using melange 0.1)
> EOF

$ mkdir -p priv
$ cat > priv/dune <<EOF
> (library
> (name priv)
> (package foo)
> (modes melange))
> EOF
$ cat > priv/priv.ml <<EOF
> let x = "private"
> EOF

$ mkdir -p lib
$ cat > lib/dune <<EOF
> (library
> (public_name foo)
> (modes melange)
> (libraries priv))
> EOF
$ cat > lib/foo.ml <<EOF
> let x = "public lib uses " ^ Priv.x
> EOF

$ cat > dune <<EOF
> (melange.emit
> (target output)
> (libraries foo)
> (emit_stdlib false))
> EOF

$ cat > entry.ml <<EOF
> let () = Js.log Foo.x
> EOF

$ dune build @melange

$ node _build/default/output/entry.js 2>&1 | grep 'Cannot find module'
Error: Cannot find module 'priv/priv.js'

$ cat _build/default/output/node_modules/foo/foo.js
// Generated by Melange
'use strict';

var Priv = require("priv/priv.js");

var x = "public lib uses " + Priv.x;

exports.x = x;
/* No side effect */