Fix EMLINK on Windows (again) #7472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicolás Ojeda Bär <[email protected]>
Signed-off-by: Nicolás Ojeda Bär <[email protected]>
emillon
pushed a commit
to emillon/dune
that referenced
this pull request
Apr 3, 2023
Signed-off-by: Nicolás Ojeda Bär <[email protected]>
|
backported in #7475, thanks |
emillon
pushed a commit
to emillon/dune
that referenced
this pull request
Apr 4, 2023
Signed-off-by: Nicolás Ojeda Bär <[email protected]>
emillon
pushed a commit
to emillon/dune
that referenced
this pull request
Apr 4, 2023
Signed-off-by: Nicolás Ojeda Bär <[email protected]>
emillon
added a commit
that referenced
this pull request
Apr 4, 2023
Signed-off-by: Nicolás Ojeda Bär <[email protected]> Co-authored-by: Nicolás Ojeda Bär <[email protected]>
emillon
added a commit
to emillon/opam-repository
that referenced
this pull request
Apr 4, 2023
…, dune-rpc, dune-rpc-lwt, dune-private-libs, dune-glob, dune-configurator, dune-build-info, dune-action-plugin and chrome-trace (3.7.1) CHANGES: - Fix segfault on MacOS when dune was being shutdown while in watch mode. (ocaml/dune#7312, fixes ocaml/dune#6151, @gridbugs, @emillon) - Fix preludes not being recorded as dependencies in the `(mdx)` stanza (ocaml/dune#7109, fixes ocaml/dune#7077, @emillon). - Pass correct flags when compiling `stdlib.ml`. (ocaml/dune#7241, @emillon) - Handle "Too many links" errors when using Dune cache on Windows. The fix in 3.7.0 for this same issue was not effective due to a typo. (ocaml/dune#7472, @nojb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #6993. Unfortunately, a typo (1142 -> 1442) meant that the fix there was useless. Also add a similar fix in the other place where
EMLINKis handled.For background (this is also explained in #6993), the Windows error code corresponding to
EMLINKisERROR_TOO_MANY_LINKS(= 1142). The mapping was fixed upstream ocaml/ocaml#11991, but is only available for OCaml >= 5.1, so we need a mitigation in Dune for previous versions.@emillon this should be backported to 3.7.1.