Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: small style tweaks #6525

Merged
merged 1 commit into from
Nov 20, 2022
Merged

refactor: small style tweaks #6525

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/dune_rules/virtual_rules.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,12 +91,12 @@ let impl sctx ~(lib : Dune_file.Library.t) ~scope =
let virtual_ =
let virtual_ = Lib_info.virtual_ info in
match virtual_ with
| Some v -> v
| None ->
User_error.raise ~loc:lib.buildable.loc
[ Pp.textf "Library %s isn't virtual and cannot be implemented"
(Lib_name.to_string implements)
]
| Some v -> v
in
let+ vlib_modules, vlib_foreign_objects =
let foreign_objects = Lib_info.foreign_objects info in
Expand All @@ -111,14 +111,14 @@ let impl sctx ~(lib : Dune_file.Library.t) ~scope =
let dir = Lib_info.src_dir info in
Dir_contents.get sctx ~dir
in
let* preprocess =
Resolve.Memo.read_memo
(Preprocess.Per_module.with_instrumentation
lib.buildable.preprocess
~instrumentation_backend:
(Lib.DB.instrumentation_backend (Scope.libs scope)))
in
let* modules =
let* preprocess =
Resolve.Memo.read_memo
(Preprocess.Per_module.with_instrumentation
lib.buildable.preprocess
~instrumentation_backend:
(Lib.DB.instrumentation_backend (Scope.libs scope)))
in
let pp_spec =
Pp_spec.make preprocess (Super_context.context sctx).version
in
Expand Down