-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert workspace detection #5206
Conversation
I forgot during the meeting, but I wonder if @rgrinberg had a similar issue with RPC (find where the rpc socket, i.e. the data provider is) , and proposed a way. |
I think what you are thinking of is discovering the list of Dune servers currently running. That won't be of much help here as merlin works even without a Dune server running. In particular, when users call |
There was a weird merge in #4913. I'm re-working the doc. |
a107548
to
4cc246c
Compare
@jeremiedimino done I had to reword a lot so it might be worth it to read it again to check that the behaviour is clear. |
Agreed. @christinerose could you have a look at the documentation changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested a few grammar things.
Looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Signed-off-by: Ulysse Gérard <[email protected]>
Signed-off-by: Ulysse Gérard <[email protected]>
Signed-off-by: Jeremie Dimino <[email protected]> Signed-off-by: Ulysse Gérard <[email protected]>
Co-authored-by: Christine Rose <[email protected]> Signed-off-by: Ulysse Gérard <[email protected]>
ba0bd71
to
44ed978
Compare
As discussed in the last dev meeting this PR restore the old root detection behavior: Dune will keep looking for an outermost
dune-workspace
file instead of stopping on the first one.This is necessary to have
dune ocaml-merlin
provide configuration for nested vendored project with their own workspace file.Fixes #5187
(partial revert of #4921)