Add default cxx link flags to ocamlmklib and ocamlc calls
#5185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I feel like this should ship with 3.0. I add the milestone. |
voodoos
force-pushed
the
cxx-link-flags
branch
from
5ffab52 to
1af549e
Compare
voodoos
commented
Nov 17, 2021
voodoos
force-pushed
the
cxx-link-flags
branch
2 times, most recently
from
2156361 to
2f00ba6
Compare
|
@jeremiedimino I think this is now ready for review |
voodoos
force-pushed
the
cxx-link-flags
branch
2 times, most recently
from
8afc027 to
a726a2d
Compare
Signed-off-by: Ulysse Gérard <[email protected]>
Signed-off-by: Ulysse Gérard <[email protected]>
Signed-off-by: Ulysse Gérard <[email protected]>
Signed-off-by: Ulysse Gérard <[email protected]>
voodoos
force-pushed
the
cxx-link-flags
branch
from
a726a2d to
59defca
Compare
2 tasks
hhugo
added a commit
to hhugo/dune
that referenced
this pull request
Dec 14, 2021
Signed-off-by: Hugo Heuzard <[email protected]>
hhugo
added a commit
to hhugo/dune
that referenced
this pull request
Dec 14, 2021
Signed-off-by: Hugo Heuzard <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Dune 3.0 the option
use_standard_c_and_cxx_flagswill be enabled by default.However an issue exist with the current implementations: all the default flags were provided at compile time and none during the link. Discussion about that issue can be found in PR #4846.
This PR fixes that by adding link time flags like
-lstdc++or-shared-libgcc(depending on the detected compiler) toocamlmklibandocamlc/optinvocations when one or more stubs is in C++.CC @recoules