Move finding the ancestor vcs to the source tree #4505
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't do that in Dune at the moment, but it is used by the Jenga rules inside Jane Street. Signed-off-by: Jeremie Dimino <[email protected]>
Signed-off-by: Jeremie Dimino <[email protected]>
ghost
requested review from
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #4504.
Parts of Dune needs to find out what vcs a given source directory is controlled by. When there is no vcs at the root of the workspace and we need the vcs of the root, we look up the file system.
At the moment, this lookup is shared with the root discovery code. Moving it to
Source_treemakesSource_treea bit more self-contained and removes the need for theSource_tree.initinitialisation function. It also means that we might list directories above the root twice:This is a bit sad, however this case is already pretty rare and will become even more rare after #4459.