Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up Dune cache testsuite #4498

Merged
merged 1 commit into from
Apr 18, 2021
Merged

Clean up Dune cache testsuite #4498

merged 1 commit into from
Apr 18, 2021

Conversation

snowleopard
Copy link
Collaborator

@snowleopard snowleopard commented Apr 17, 2021 •
edited
Loading

This PR does a few things:

  • Replace almost duplicate tests, such as dedup.t, dedup-direct.t and dedup-direct-copy.t with just one dedup.t that does all the necessary checks. This can be simplified now that we don't have the cache daemon.
  • Drop the environment variable DUNE_CACHE_EXIT_NO_CLIENT=1 which is apparently unused.
  • Reword some outdated test descriptions.
  • Add a few new tests to improve the coverage of the cache functionality.

@snowleopard snowleopard requested review from rgrinberg, a user and aalekseyev April 17, 2021 23:35
@snowleopard
Clean up Dune cache testsuite
a73e229 
Signed-off-by: Andrey Mokhov <[email protected]>
@snowleopard snowleopard force-pushed the clean-up-cache-tests branch from a5a45f0 to a73e229 Compare April 17, 2021 23:35
@snowleopard snowleopard merged commit 4933706 into ocaml:main Apr 18, 2021
@snowleopard snowleopard deleted the clean-up-cache-tests branch April 18, 2021 10:56
@snowleopard snowleopard mentioned this pull request Sep 23, 2021
Closed
@smorimoto smorimoto mentioned this pull request Jan 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgrinberg rgrinberg rgrinberg approved these changes

@aalekseyev aalekseyev Awaiting requested review from aalekseyev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@snowleopard @rgrinberg