Print an error when seeing a cram stanza and cram tests are not enabled #4245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this case and if there is indeed a cram test, "dune runtest" does nothing, which is bad. Signed-off-by: Jeremie Dimino <[email protected]>
It is a wanning for lang dune < 3.0 Signed-off-by: Jeremie Dimino <[email protected]>
ghost
requested a review
from 
ghost
mentioned this pull request
rgrinberg
approved these changes
Feb 19, 2021
|
In that case, Maybe we should make Dune not emit such warnings in vendored projects, the same way we tell the compiler to ignore warnings in vendored projects. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is a warning for lang dune < 3.0.
I spent a good 10 minutes the other day trying to understand why
dune runtestwas doing nothng. Turns out it was because I had forgotten to write(cram enable)in mydune-projectfile. This PR fixes that.