odoc - stop dune from generating docs for hidden modules #3894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lubegasimon
commented
Oct 25, 2020
lubegasimon
commented
Oct 26, 2020
lubegasimon
force-pushed
the
Change/stop-dune-from-generating-docs-for-hidden-modules
branch
from
e7bf7ef to
a421b5e
Compare
rgrinberg
reviewed
Oct 27, 2020
rgrinberg
reviewed
Oct 27, 2020
lubegasimon
force-pushed
the
Change/stop-dune-from-generating-docs-for-hidden-modules
branch
from
a421b5e to
49ecc2c
Compare
jonludlam
reviewed
Nov 10, 2020
lubegasimon
force-pushed
the
Change/stop-dune-from-generating-docs-for-hidden-modules
branch
2 times, most recently
from
eeed25c to
9a0d0ee
Compare
lubegasimon
force-pushed
the
Change/stop-dune-from-generating-docs-for-hidden-modules
branch
3 times, most recently
from
bd85bec to
56981b4
Compare
2. adding linking phase in favor of command Signed-off-by: lubegasimon <[email protected]>
Signed-off-by: lubegasimon <[email protected]>
Signed-off-by: lubegasimon <[email protected]>
Signed-off-by: lubegasimon <[email protected]>
…ules Signed-off-by: lubegasimon <[email protected]>
lubegasimon
force-pushed
the
Change/stop-dune-from-generating-docs-for-hidden-modules
branch
from
56981b4 to
bcd4770
Compare
|
Closed in favour of #5045 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In odoc release
1.5.1, generation of documentation for hidden modules ( module names with__) is enabled, odoc team, proposed the former to be disabled, CC @jonludlam, that is by letting dune know of it, thus stop building docs for the hidden modules.