Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split Stanza_common from include stanza #3782

Merged
merged 2 commits into from
Sep 11, 2020
Merged

Split Stanza_common from include stanza #3782

merged 2 commits into from
Sep 11, 2020

Conversation

rgrinberg
Copy link
Member

This allows to move most of the module to dune_rules. Since only the
include stanza is necessary in dune_engine.

@rgrinberg
Do not open Stanza_common
966b31f 
Signed-off-by: Rudi Grinberg <[email protected]>
@rgrinberg
Split Stanza_common from include stanza
1f08ecf 
This allows to move most of the module to dune_rules. Since only the
include stanza is necessary in dune_engine.

Signed-off-by: Rudi Grinberg <[email protected]>
cwong-ocaml
cwong-ocaml approved these changes Sep 11, 2020
View reviewed changes
Copy link
Collaborator

@cwong-ocaml cwong-ocaml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. Do you think there's any real reason include_stanza needs to be in the backend, or is that just a task for a different day?

@cwong-ocaml cwong-ocaml removed the request for review from CT075 September 11, 2020 20:24
@rgrinberg
Copy link
Member Author

Looks fine to me. Do you think there's any real reason include_stanza needs to be in the backend, or is that just a task for a different day?

It's used by File_tree which is much tougher to extract out of the engine.

@rgrinberg rgrinberg merged commit 7bfd8df into ocaml:master Sep 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwong-ocaml cwong-ocaml cwong-ocaml approved these changes

@aalekseyev aalekseyev Awaiting requested review from aalekseyev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rgrinberg @cwong-ocaml