Return [result] from [Workspace_root.create] #10894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgrinberg
reviewed
Sep 9, 2024
gridbugs
force-pushed
the
workspace-root-create-result
branch
from
e60c7d7 to
cc34dbe
Compare
rgrinberg
approved these changes
Sep 10, 2024
This makes it possible to check whether the user is currently inside a dune project. This is needed for dev-tools to have fallback behaviour when run outside of a dune project which is necessary to allow users to configure their editors to invoke dev-tools via dune. For example, if a user configures their editor to start ocamllsp with the command `dune ocamllsp`, dune needs to be able to handle the case where the user edits an ocaml file outside of a dune project, for example by attempting to invoke ocamllsp from PATH. Signed-off-by: Stephen Sherratt <[email protected]>
gridbugs
force-pushed
the
workspace-root-create-result
branch
from
cc34dbe to
b14a680
Compare
anmonteiro
pushed a commit
to anmonteiro/dune
that referenced
this pull request
Nov 17, 2024
This makes it possible to check whether the user is currently inside a dune project. This is needed for dev-tools to have fallback behaviour when run outside of a dune project which is necessary to allow users to configure their editors to invoke dev-tools via dune. For example, if a user configures their editor to start ocamllsp with the command `dune ocamllsp`, dune needs to be able to handle the case where the user edits an ocaml file outside of a dune project, for example by attempting to invoke ocamllsp from PATH. Signed-off-by: Stephen Sherratt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to check whether the user is currently inside a dune project. This is needed for dev-tools to have fallback behaviour when run outside of a dune project which is necessary to allow users to configure their editors to invoke dev-tools via dune. For example, if a user configures their editor to start ocamllsp with the command
dune ocamllsp, dune needs to be able to handle the case where the user edits an ocaml file outside of a dune project, for example by attempting to invoke ocamllsp from PATH.