Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cinaps stanza 1.0 fails to build the cinaps executable under arm32 #4069

Closed
NathanReb opened this issue Dec 29, 2020 · 1 comment · Fixed by #4085 or ocaml/opam-repository#17967
Closed

Cinaps stanza 1.0 fails to build the cinaps executable under arm32 #4069

NathanReb opened this issue Dec 29, 2020 · 1 comment · Fixed by #4085 or ocaml/opam-repository#17967

Comments

@NathanReb
Copy link
Collaborator

Expected Behavior

Everything should work fine under arm32.

Actual Behavior

From what I gathered from ocaml-ci's log, it appears that building the cgenerated cinaps executable fails, getting relocation errors from ld. I'm guessing this might be due to missing flags along the chain somewhere. The dune runtest fails with the following:

(cd _build/default && /home/opam/.opam/4.11/bin/ocamlopt.opt -w -24 -o lib/.cinaps/cinaps.exe /home/opam/.opam/4.11/lib/ocaml/unix.cmxa -I /home/opam/.opam/4.11/lib/ocaml /home/opam/.opam/4.11/lib/cinaps/runtime/cinaps_runtime.cmxa lib/.cinaps/.cinaps.eobjs/native/dune__exe__Cinaps.cmx)
/usr/bin/ld: lib/.cinaps/.cinaps.eobjs/native/dune__exe__Cinaps.o: relocation R_ARM_THM_MOVW_ABS_NC against `camlCinaps_runtime' can not be used when making a shared object; recompile with -fPIC
/usr/bin/ld: lib/.cinaps/.cinaps.eobjs/native/dune__exe__Cinaps.o: in function `.L111':
:(.text+0xfc): dangerous relocation: unsupported relocation
/usr/bin/ld: :(.text+0x100): dangerous relocation: unsupported relocation
/usr/bin/ld: :(.text+0x104): dangerous relocation: unsupported relocation
/usr/bin/ld: :(.text+0x108): dangerous relocation: unsupported relocation
/usr/bin/ld: lib/.cinaps/.cinaps.eobjs/native/dune__exe__Cinaps.o: in function `camlDune__exe__Cinaps__6':
:(.data+0x4): dangerous relocation: unsupported relocation
...

Reproduction

I wrote a minimal example here: https://github.com/NathanReb/dune-cinaps-arm32
I openend a dummy PR on the repo to trigger an ocaml-ci build, here is the arm32 build: https://ci.ocamllabs.io/github/NathanReb/dune-cinaps-arm32/commit/c5312927c1f56868dae15c9c6762d022e6faaaf8/variant/debian-10-4.11_arm32

Specifications

  • Version of dune (output of dune --version): 2.7.1
  • Version of ocaml (output of ocamlc --version): 4.11.1
  • Operating system (distribution and version): linux-arm64:debian-10-4.11_arm32
@NathanReb NathanReb mentioned this issue Jan 4, 2021
Open
@emillon
Copy link
Collaborator

emillon commented Jan 5, 2021

I had a look and it's related to the MOVW/MOVT instructions emitted by the arm backend when -nodynlink is passed. This is similar to #2527 (ocaml issue: ocaml/ocaml#8867) and passing dynlink:true here fixes the issue:

dune/src/dune_rules/cinaps.ml

Line 104 in bbbbc67

~js_of_ocaml:None ~dynlink:false ~package:None

I'll open a PR with that; curious to see if we can fix it more globally because it seems that it will cause problems in other places like inline tests that build a compilation context with dynlink:false.

emillon added a commit to emillon/dune that referenced this issue Jan 5, 2021
@emillon
Fix cinaps on arm32
1d1a901 
Closes ocaml#4069

When `dynlink:false` is passed, the ARM backend emits MOVW/MOVT
instructions which have relocations incompatible with PIC code.
This is similar to ocaml#2527 (ocaml issue: ocaml/ocaml#8867).

Signed-off-by: Etienne Millon <[email protected]>
@emillon emillon mentioned this issue Jan 5, 2021
Closed
emillon added a commit to emillon/dune that referenced this issue Jan 5, 2021
@emillon
Fix cinaps on arm32
8212983 
Closes ocaml#4069

When `dynlink:false` is passed, the ARM backend emits MOVW/MOVT
instructions which have relocations incompatible with PIC code.
This is similar to ocaml#2527 (ocaml issue: ocaml/ocaml#8867).

Signed-off-by: Etienne Millon <[email protected]>
emillon added a commit that referenced this issue Jan 6, 2021
@emillon
Never pass -nodynlink option
4baa5ac 
This is an optimization when PIC executables are not used, but this
optimization is disabled becauses it causes errors on arm32. Most
distributions are going in the direction of requiring PIC, and
`-nodynlink` might go away (see ocaml/ocaml#8867), so the supporting
code in dune (which is bypassed in most cases) can be removed.

Closes #4069
Closes #2527

Signed-off-by: Etienne Millon <[email protected]>
@emillon emillon mentioned this issue Jan 6, 2021
Merged
emillon added a commit that referenced this issue Jan 6, 2021
@emillon
Never pass -nodynlink option
4dd621e 
This is an optimization when PIC executables are not used, but this
optimization is disabled becauses it causes errors on arm32. Most
distributions are going in the direction of requiring PIC, and
`-nodynlink` might go away (see ocaml/ocaml#8867), so the supporting
code in dune (which is bypassed in most cases) can be removed.

Closes #4069
Closes #2527

Signed-off-by: Etienne Millon <[email protected]>
emillon added a commit that referenced this issue Jan 11, 2021
@emillon
Never pass -nodynlink option
8b2b0af 
This is an optimization when PIC executables are not used, but this
optimization is disabled becauses it causes errors on arm32. Most
distributions are going in the direction of requiring PIC, and
`-nodynlink` might go away (see ocaml/ocaml#8867), so the supporting
code in dune (which is bypassed in most cases) can be removed.

Closes #4069
Closes #2527

Signed-off-by: Etienne Millon <[email protected]>
emillon added a commit that referenced this issue Jan 11, 2021
@emillon
Never pass -nodynlink option (#4085)
563f4bb 
This is an optimization when PIC executables are not used, but this
optimization is disabled becauses it causes errors on arm32. Most
distributions are going in the direction of requiring PIC, and
`-nodynlink` might go away (see ocaml/ocaml#8867), so the supporting
code in dune (which is bypassed in most cases) can be removed.

Closes #4069
Closes #2527

Signed-off-by: Etienne Millon <[email protected]>
@rgrinberg rgrinberg mentioned this issue Jan 13, 2021
Merged
rgrinberg added a commit to rgrinberg/opam-repository that referenced this issue Jan 13, 2021
@rgrinberg
[new release] dune-build-info, dune, dune-configurator, dune-site, du…
dbe0014 
…ne-action-plugin, dune-private-libs and dune-glob (2.8.0)

CHANGES:

- `dune rules` accepts aliases and other non-path rules (ocaml/dune#4063, @mrmr1993)

- Action `(diff reference test_result)` now accept `reference` to be absent and
  in that case consider that the reference is empty. Then running `dune promote`
  will create the reference file. (ocaml/dune#3795, @bobot)

- Ignore special files (BLK, CHR, FIFO, SOCKET), (ocaml/dune#3570, fixes ocaml/dune#3124, ocaml/dune#3546,
  @ejgallego)

- Experimental: Simplify loading of additional files (data or code) at runtime
  in programs by introducing specific installation sites. In particular it allow
  to define plugins to be installed in these sites. (ocaml/dune#3104, ocaml/dune#3794, fixes ocaml/dune#1185,
  @bobot)

- Move all temporary files created by dune to run actions to a single directory
  and make sure that actions executed by dune also use this directory by setting
  `TMPDIR` (or `TEMP` on Windows). (ocaml/dune#3691, fixes ocaml/dune#3422, @rgrinberg)

- Fix bootstrap script with custom configuration. (ocaml/dune#3757, fixes ocaml/dune#3774, @marsam)

- Add the `executable` field to `inline_tests` to customize the compilation
  flags of the test runner executable (ocaml/dune#3747, fixes ocaml/dune#3679, @lubegasimon)

- Add `(enabled_if ...)` to `(copy_files ...)` (ocaml/dune#3756, @nojb)

- Make sure Dune cleans up the status line before exiting (ocaml/dune#3767,
  fixes ocaml/dune#3737, @alan-j-hu)

- Add `{gitlab,bitbucket}` as options for defining project sources with `source`
  stanza `(source (<host> user/repo))` in the `dune-project` file.  (ocaml/dune#3813,
  @rgrinberg)

- Fix generation of `META` and `dune-package` files when some targets (byte,
  native, dynlink) are disabled. Previously, dune would generate all archives
  for regardless of settings. (ocaml/dune#3829, ocaml/dune#4041, @rgrinberg)

- Do not run ocamldep to for single module executables & libraries. The
  dependency graph for such artifacts is trivial (ocaml/dune#3847, @rgrinberg)

- Fix cram tests inside vendored directories not being interpreted correctly.
  (ocaml/dune#3860, fixes ocaml/dune#3843, @rgrinberg)

- Add `package` field to private libraries. This allows such libraries to be
  installed and to be usable by other public libraries in the same project
  (ocaml/dune#3655, fixes ocaml/dune#1017, @rgrinberg)

- Fix the `%{make}` variable on Windows by only checking for a `gmake` binary
  on UNIX-like systems as a unrelated `gmake` binary might exist on Windows.
  (ocaml/dune#3853, @kit-ty-kate)

- Fix `$ dune install` modifying the build directory. This made the build
  directory unusable when `$ sudo dune install` modified permissions. (fix
  ocaml/dune#3857, @rgrinberg)

- Fix handling of aliases given on the command line (using the `@` and `@@`
  syntax) so as to correctly handle relative paths. (ocaml/dune#3874, fixes ocaml/dune#3850, @nojb)

- Allow link time code generation to be used in preprocessing executable. This
  makes it possible to use the build info module inside the preprocessor.
  (ocaml/dune#3848, fix ocaml/dune#3848, @rgrinberg)

- Correctly call `git ls-tree` so unicode files are not quoted, this fixes
  problems with `dune subst` in the presence of unicode files. Fixes ocaml/dune#3219
  (ocaml/dune#3879, @ejgallego)

- `dune subst` now accepts common command-line arguments such as
  `--debug-backtraces` (ocaml/dune#3878, @ejgallego)

- `dune describe` now also includes information about executables in addition to
  that of libraries. (ocaml/dune#3892, ocaml/dune#3895, @nojb)

- instrumentation backends can now receive arguments via `(instrumentation
  (backend <name> <args>))`. (ocaml/dune#3906, ocaml/dune#3932, @nojb)

- Tweak auto-formatting of `dune` files to improve readability. (ocaml/dune#3928, @nojb)

- Add a switch argument to opam when context is not default. (ocaml/dune#3951, @tmattio)

- Avoid pager when running `$ git diff` (ocaml/dune#3912, @AltGr)

- Add `(root_module ..)` field to libraries & executables. This makes it
  possible to use library dependencies shadowed by local modules (ocaml/dune#3825,
  @rgrinberg)

- Allow `(formatting ...)` field in `(env ...)` stanza to set per-directory
  formatting specification. (ocaml/dune#3942, @nojb)

- [coq] In `coq.theory`, `:standard` for the `flags` field now uses the
  flags set in `env` profile flags (ocaml/dune#3931 , @ejgallego @rgrinberg)

- [coq] Add `-q` flag to `:standard` `coqc` flags , fixes ocaml/dune#3924, (ocaml/dune#3931 , @ejgallego)

- Add support for Coq's native compute compilation mode (@ejgallego, ocaml/dune#3210)

- Add a `SUFFIX` directive in `.merlin` files for each dialect with no
  preprocessing, to let merlin know of additional file extensions (ocaml/dune#3977,
  @vouillon)

- Stop promoting `.merlin` files. Write per-stanza Merlin configurations in
  binary form. Add a new subcommand `dune ocaml-merlin` that Merlin can use to
  query the configuration files. The `allow_approximate_merlin` option is now
  useless and deprecated. Dune now conflicts with `merlin < 3.4.0` and
  `ocaml-lsp-server < 1.3.0` (ocaml/dune#3554, @voodoos)

- Configurator: fix a bug introduced in 2.6.0 where the configurator V1 API
  doesn't work at all when used outside of dune. (ocaml/dune#4046, @aalekseyev)

- Fix `libexec` and `libexec-private` variables. In cross-compilation settings,
  they now point to the file in the host context. (ocaml/dune#4058, fixes ocaml/dune#4057,
  @TheLortex)

- When running `$ dune subst`, use project metadata as a fallback when package
  metadata is missing. We also generate a warning when `(name ..)` is missing in
  `dune-project` files to avoid failures in production builds.

- Remove support for passing `-nodynlink` for executables. It was bypassed in
  most cases and not correct in other cases in particular on arm32.
  (ocaml/dune#4085, fixes ocaml/dune#4069, fixes ocaml/dune#2527, @emillon)

- Generate archive rules compatible with 4.12. Dune longer attempt to generate
  an archive file if it's unnecessary (ocaml/dune#3973, fixes ocaml/dune#3766, @rgrinberg)

- Fix generated Merlin configurations when multiple preprocessors are defined
  for different modules in the same folder. (ocaml/dune#4092, fixes ocaml/dune#2596, ocaml/dune#1212 and
  ocaml/dune#3409, @voodoos)

- Add the option `use_standard_c_and_cxx_flags` to `dune-project` that 1.
  disables the unconditional use of the `ocamlc_cflags` and `ocamlc_cppflags`
  from `ocamlc -config` in C compiler calls, these flags will be present in the
  `:standard` set instead; and 2. enables the detection of the C compiler family
  and populates the `:standard` set of flags with common default values when
  building CXX stubs. (ocaml/dune#3875, ocaml/dune#3802, fix ocaml/dune#3718 and ocaml/dune#3528, @voodoos)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@emillon @NathanReb