Remove some calls to if_newline and break_unless_newline and fix break before closing brackets

[gpetiot]

Still on the way to remove calls to our custom Format functions.

Only b6208ad produces a diff.
No diff with janestreet profile.
Diff with conventional profile:

diff --git a/sledge/src/llair/frontend.ml b/sledge/src/llair/frontend.ml
index 6f0ebabff..115fa2834 100644
--- a/sledge/src/llair/frontend.ml
+++ b/sledge/src/llair/frontend.ml
@@ -932,7 +932,6 @@ let xlate_instr :
           | [
               "_ZnwmSt11align_val_t";
               (* operator new(unsigned long, std::align_val_t) *)
-              
             ] ->
               let reg = xlate_name x instr in
               let num = xlate_value x (Llvm.operand instr 0) in
@@ -942,12 +941,10 @@ let xlate_instr :
           | [
               "_ZdlPvSt11align_val_t";
               (* operator delete(void* ptr, std::align_val_t) *)
-              
             ]
           | [
               "_ZdlPvmSt11align_val_t";
               (* operator delete(void* ptr, unsigned long, std::align_val_t) *)
-              
             ]
           | [ "free" (* void free(void* ptr) *) ] ->
               let ptr = xlate_value x (Llvm.operand instr 0) in
@@ -1055,7 +1052,6 @@ let xlate_instr :
       | [
           "_ZnwmSt11align_val_t";
           (* operator new(unsigned long num, std::align_val_t) *)
-          
         ]
         when num_actuals > 0 ->
           let reg = xlate_name x instr in

[jberdine]

Diff with conventional profile:

And with the config specified for the code being tested on?

[gpetiot]

Here is the diff with the original config:

diff --git a/sledge/src/llair/frontend.ml b/sledge/src/llair/frontend.ml
index 3ffdbd279..227860071 100644
--- a/sledge/src/llair/frontend.ml
+++ b/sledge/src/llair/frontend.ml
@@ -955,7 +955,7 @@ let xlate_instr :
             (* operator delete(void* ptr, std::align_val_t) *) ]
          |[ "_ZdlPvmSt11align_val_t"
             (* operator delete(void* ptr, unsigned long, std::align_val_t) *)
-           ]
+          ]
          |["free" (* void free(void* ptr) *)] ->
             let ptr = xlate_value x (Llvm.operand instr 0) in
             emit_inst (Llair.Inst.free ~ptr ~loc)

[jberdine]

Nice. It is good to see if_newline going away. It and the standard one both have quite strange behavior regarding the computation of the length of a box's contents, and hence whether or not it breaks.

[Julow]

Looks good ! All the diffs look like fixes.