Fix --enable-outside-detected-project #1156
Conversation
…rking Since 45f324, parsing of option is done later in that file, after those options are checked at toplevel.
|
Hi Julow! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
* Add tests for --enable-outside-detected-project * Fix --enable-outside-detected-project and --root options no longer working Since 45f324, parsing of option is done later in that file, after those options are checked at toplevel.
Fix #1154
Bug introduced in #1127 (on master: 45f324)
The parsing of option has been moved after that option is checked, at toplevel.
Same for the
--rootoption, but I didn't manage to make it work yet while writing tests.