Add command line tests #1117
Add command line tests #1117
Conversation
|
Hi Julow! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
| if b then Format.kfprintf (fun _ -> false) Format.err_formatter | ||
| else Format.ikfprintf (fun _ -> ok) Format.err_formatter | ||
| in | ||
| let ok = e ok (not entry.has_ref) "@{<error>Error@}: Missing file %s.ref\n" test_name in |
There was a problem hiding this comment.
I think you can simplify this part by using invalid_arg as it's only used to exit with an error message
There was a problem hiding this comment.
I did that way to print all the warnings before exiting. Do you think I should remove that feature ?
|
Thanks! |
So we can avoid regressions.
Also adds a few tests for invalid combinations of options.
It's not complete, there is a lot more to test.