Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Regression: comment position in list patterns #1140

Closed
jberdine opened this issue Nov 13, 2019 · 0 comments · Fixed by #1141
Closed

Bug: Regression: comment position in list patterns #1140

jberdine opened this issue Nov 13, 2019 · 0 comments · Fixed by #1141
Milestone

Comments

@jberdine
Copy link
Collaborator

Describe the bug
#866 introduced a regression in the position of comments in list patterns.

How to Reproduce
Executing

$ echo "let [(* comment one *) one; (* comment two *) two] = [1; 2]" | _build/default/src/ocamlformat.exe --name "foo.ml" -

produces

let (* comment one *) [one; (* comment two *) two] = [1; 2]

while it should, and used to, produce

let [(* comment one *) one; (* comment two *) two] = [1; 2]
jberdine added a commit that referenced this issue Nov 13, 2019
jberdine added a commit that referenced this issue Nov 13, 2019
@gpetiot gpetiot added this to the 0.13.0 milestone Nov 21, 2019
gpetiot pushed a commit that referenced this issue Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants