Remove ctypes include path hack #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great. Thanks! |
Sudha247
added a commit
to Sudha247/opam-repository
that referenced
this pull request
Feb 23, 2023
CHANGES: * Add memory_size function (@crackcomm, ocaml-multicore/hdr_histogram_ocaml#1) * Change memory_size return type to int (@crackcomm, ocaml-multicore/hdr_histogram_ocaml#2) * Fix build with dune 3.6 (@emillon, ocaml-multicore/hdr_histogram_ocaml#3) * Remove ctypes include path hack by using ctypes 0.3 / dune 3.7 (@TheLortex, ocaml-multicore/hdr_histogram_ocaml#5)
|
Ah great to see that it works in the wild :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables using hdr_histogram_ocaml in a monorepo.
Thanks to ocaml/dune#6883 (merged in dune 3.7), the ctypes rule is interpreted in the folder where it is defined. This means we can use relative paths and everything works as expected.