RFC 8259 compliance tests #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a test suite for RFC 8259 compliance, as suggested in #34.
It is not run as part of the main test suite yet but via
dune build @compliance-testsand has a pretty verbose output.Next step is to decide what to do with the 11 failures and to eventually include part of these test cases to the main test suite. For instance it'd be good to ensure that all Yojson modules accept all the valid JSON from this test suite.
Because changing the behaviour of the current parsers might break some users code, I'm considering adding a
Yojson.Standard, which typetwould be compatible withYojson.Basic.tbut that would only accept and emit compliant JSON. What to do with the other modules is still to be determined as part of the plan for2.0.0.