-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JSON5 support (PR with fixes) #176
Closed
Leonidas-from-XIV
wants to merge
21
commits into
ocaml-community:master
from
Leonidas-from-XIV:json5-parser-implementation
Closed
JSON5 support (PR with fixes) #176
Leonidas-from-XIV
wants to merge
21
commits into
ocaml-community:master
from
Leonidas-from-XIV:json5-parser-implementation
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The lexer should return a string, no need to add double or single quotes when lexing, they are not the content of the string.
Merged
Leonidas-from-XIV
force-pushed
the
json5-parser-implementation
branch
from
April 26, 2024 14:18
5526978
to
652403a
Compare
I was able to push to #152 therefore closing this temporary PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I can't push to #152 this is a (hopefully temporary) PR to add my commits on top of that branch.