-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable ocamlformat
on the part of the codebase that doesn't use CPPO
#153
Enable ocamlformat
on the part of the codebase that doesn't use CPPO
#153
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve. I would also suggest adding a .git-blame-ignore-revs
so that git blame
output more meaningful result.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In fact, currently not only .cppo.ml
contains cppo instructions, see for instance monomorphic.ml
.
They should either be renamed, or added to the ocamlformat-ignore
!
32c4e49
to
0237393
Compare
Oh yes, that's true, you're right. I somehow assumed only the Also, I added the revision of the commit to the file. Unfortunately, there's no default name that git would pick up and users need to configure git for this to work but adding it won't hurt. Can you please take another look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Also, I added the revision of the commit to the file. Unfortunately, there's no default name that git would pick up and users need to configure git for this to work but adding it won't hurt.
I think .git-blame-ignore-revs
is the name that github picks, so it's at least directly useful in the github interface. (https://docs.github.com/en/repositories/working-with-files/using-files/viewing-a-file#ignore-commits-in-the-blame-view)
Ah, that's great to know, definitely useful! |
This enables
ocamlformat
on the subset of the codebase that does not use CPPO.