improve pretty printing #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c-cube
requested review from
NathanReb,
panglesd and
Leonidas-from-XIV
as code owners
c-cube
force-pushed
the
tmp-pretty-2022-06-03
branch
from
e78f9f3 to
2435aac
Compare
Leonidas-from-XIV
requested changes
Jun 3, 2022
CHANGES.md
Outdated
| @@ -41,6 +41,7 @@ | |||
| - Avoid copying unnecessarily large amounts of strings when parsing (#85, #108, | |||
| @Leonidas-from-XIV) | |||
| - Fix `stream_to_file` (#133, @tcoopman and @gasche) | |||
| - Fix pretty-printing behavior for lists/objects inside lists | |||
There was a problem hiding this comment.
This should actually go into a new unreleased section, I'll push this on master.
c-cube
force-pushed
the
tmp-pretty-2022-06-03
branch
from
1a56a79 to
e36bbfe
Compare
3 tasks
|
Don't you want to reserve wrapping (hov box) for only sequences of "atoms" (null, boolean, number, string, |
|
Ah, that's interesting. I didn't realize it was done this way, but it makes sense (hv box for big objects is nicer). I think it can wait but that's just my personal opinion, and if you want to make a PR it'll make @Leonidas-from-XIV happy :) |
Leonidas-from-XIV
added a commit
to Leonidas-from-XIV/opam-repository
that referenced
this pull request
Jun 28, 2022
CHANGES: *2022-06-28* ### Fixed - Fix pretty-printing behavior for lists/objects inside lists (@c-cube ocaml-community/yojson#141, @mjambon ocaml-community/yojson#142)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cf #140