Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove validate_json #137

Merged
merged 2 commits into from
Mar 9, 2022
Merged

Remove validate_json #137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f49e9b6
Remove `validate_json`
Leonidas-from-XIV Mar 7, 2022
096e093
Set PR number
Leonidas-from-XIV Mar 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@
- Removed `json_max` type (@Leonidas-from-XIV, #103)
- Removed constraint that the "root" value being rendered (via either
`pretty_print` or `to_string`) must be an object or array. (@cemerick, #121)
- Removed `validate_json` as it only made sense if the type was called `json`.
(@Leonidas-from-XIV, #137)

### Add

Expand Down
7 changes: 0 additions & 7 deletions lib/read.mli
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,12 +261,5 @@ val read_json : lexer_state -> Lexing.lexbuf -> t
val skip_json : lexer_state -> Lexing.lexbuf -> unit
val buffer_json : lexer_state -> Lexing.lexbuf -> unit

val validate_json : 'path -> t -> 'error option
(* always returns [None].
Provided so that atdgen users can write:

type t <ocaml module="Yojson.Safe"> = abstract
*)

(* end undocumented section *)
(**/**)
2 changes: 0 additions & 2 deletions lib/read.mll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1212,6 +1212,4 @@ and junk = parse

let compact ?std s =
to_string (from_string s)

let validate_json _path _value = None
}