Benchmark +fp against mainline 5.1.1 #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Motivated by, |
You can use
You set the expiry to be a few days from now, just to capture a snapshot of the benchmarks. We currently run benchmarks against the latest OCaml trunk every night, and configure benchmarks against specific branches for short periods, just to collect some snapshots of the data. |
punchagan
reviewed
Mar 18, 2024
config/custom_navajo.json
Outdated
| { | ||
| "url": "https://github.com/ocaml/ocaml/archive/5.1.1.tar.gz", | ||
| "name": "5.1.1+fp", | ||
| "expiry": "2100-01-01" |
There was a problem hiding this comment.
You probably want to add something like this, here:
"configure": "--enable-frame-pointers",
1. Fix expiry date: to next week 2. Use +trunk in the name 3. Use --enable-framepointer flag for fp variant
ManasJayanth
force-pushed
the
prometheansacrifice/fp-against-mainline-5.1.1
branch
from
c380fce to
227fad1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new post about frame pointers by Brendan Gregg has made me curious about how the
+fpvariant of the compiler performs against mainline.Notes for reviewer:
5.1.1or5.1.1+stable?