Memory fixes

[i-n-g-o]

Hi.

I came across this, when i was using the threaded-version of ofxAVFVideoPlayer (ofxAVFThreadedVideoPlayer).

Actually this PR contains two changes. It might be "better" to seperate the to things, but somehow they are related.

First:
I added a switch to control if the audio gets loaded into the internal buffer or not. The default behavior is how it was before the change (loading audio)
getter: shouldLoadAudio, setter: setShouldLoadAudio:

Second:
When i was testing with the threaded version for a longer time i came across a memory leak. i digged in and found the following:

• when destroying (or closing) the ofxAVFVideoPlayer and if it was never played (but a file was loaded), the moviePlayer object was not getting freed because the timeObserver holds a reference to it.
• even if cleaning up the timeObserver there was something else going on. so i made sure, that the blocks scheduled by the timeObserver are not holding a reference to the moviePlayer object. Using __block variables and a __block reference to self (in ofxAVFVideoRenderer)
• i created the dispatch_queue before using it, in order to be able to sync with the queue and to free it on cleanup
• a memory-leak at the first iteration when reading audio-data. sampleBuffer has to be released.

[prisonerjohn]

Cool, thanks for this. I was aware there was a leak in the audio stuff but never had the time to really look into it. A lot of this addon (minus the audio stuff) got merged into the core, maybe we can now add the audio read in as well.

Do you think you could do a pass to fix indentation and remove debug traces before I merge this?

[i-n-g-o]

i had a look at the implementation of the AVPlayer in the current master and created a PR which would fix a potential memory leak:
openframeworks/openFrameworks#3672

i suspect also something else going on in this addon, but i cannot name it at the moment. i am a bit out of the loop about this, but will come back to that sometimes soon.

sure, i will have a look at the indentations and the left debug things and create a new PR.

[prisonerjohn]

Great, FYI you can just push the changes to the same branch and they'll go in this PR.

[i-n-g-o]

all right, fixed the indentations and removed the debug logs
also fixed a log whre QTRenderer is mentioned ;)

[prisonerjohn]

Thanks!

[obviousjim]

thx!!

On Sun, Mar 15, 2015 at 10:03 AM, Elie Zananiri [email protected]
wrote:

Thanks!

—
Reply to this email directly or view it on GitHub
#7 (comment)
.

• James