Create folder for 'SetRecordingFolder' if it does not exist #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fireph
changed the title
|
Any chance someone could take a look at this? It would be really nice to have this merged in for an app I am making :) |
|
@DungFu Looks good to me. Thanks for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using 'SetRecordingFolder', it will fail if the folder does not already exist. If one wants to save recordings to changing folders (such as a different folder for each game), this is not possible without running an extra program/script.
This pull request changes obs-websocket to try to create the directory (and all intermediaries) when using 'SetRecordingFolder' to solve this issue.