Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Use Qt6 by default when available #6877

Merged
merged 1 commit into from
Jul 31, 2022
Merged

Conversation

RytoEX
Copy link
Member

@RytoEX RytoEX commented Jul 31, 2022

Description

Use Qt6 by default when available. This applies to the Windows, macOS, and Ubuntu CI jobs.

Motivation and Context

As announced on May 14, we plan to use Qt6 for OBS 28 on platforms where it is available. CI and build scripts should default to Qt6 to encourage adoption of Qt6 by plugin maintainers. This will also help us during our beta and release candidate period.

As stated in the Discussion post, moving to Qt6 also allows us to stop maintaining backported patches, which reduces our maintenance burden.

How Has This Been Tested?

I've verified that CI runs on my fork build with Qt6 when available (Windows, macOS, Ubuntu 22.04) and Qt5 when not available (Ubuntu 20.04). Flatpak will be covered in #6847.
https://github.com/RytoEX/obs-studio/actions/runs/2768057341

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@RytoEX RytoEX added Bug Fix Non-breaking change which fixes an issue New Feature New feature or plugin CI labels Jul 31, 2022
@RytoEX RytoEX requested a review from PatTheMav July 31, 2022 04:28
@gxalpha gxalpha added this to the OBS Studio 28.0 milestone Jul 31, 2022
@RytoEX RytoEX merged commit b4e056f into obsproject:master Jul 31, 2022
@RytoEX RytoEX deleted the qt6-build branch July 31, 2022 17:46
@SuslikV
Copy link
Contributor

SuslikV commented Aug 2, 2022

CI builds for Windows platform from this time will run only on Win8.1 and up (dependencies, that were updated here, relay on functions of dxgi library that are specific to newer OSes).

@RytoEX
Copy link
Member Author

RytoEX commented Aug 2, 2022

CI builds for Windows platform from this time will run only on Win8.1 and up (dependencies, that were updated here, relay on functions of dxgi library that are specific to newer OSes).

That's expected and was announced in the pinned May 14 Discussion Post, Plan to Upgrade OBS Studio to Qt 6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Fix Non-breaking change which fixes an issue CI New Feature New feature or plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants