-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies #245
Update dependencies #245
Conversation
Good newsOBS builds in Debug, RelWithDebInfo, and Release. These worked:
Everything in my typical tests for those features worked. Bad NewsThese do not work:
Apparently there are build errors on macOS at the moment. The Qt download failure seems like a sporadic failure. Will re-run CI later after trying to address the diverged patch for libpng. On Windows, while I can build in RelWithDebInfo and Release, I cannot start the application. It looks like the RelWithDebInfo and Release builds somehow marked the Qt Debug DLLs (e.g., Qt6Cored.dll) as the necessary runtime DLLs instead of the Release DLLs (Qt6Core.dll). This seems to be a side effect of this change in Qt: This results in these files inside the
Since I locally built Qt in Release first and then in Debug, these files all pointed to the Qt Debug DLLs as the "obs-studio_RUNTIME_DLLS":
Not sure what to do about that. Additionally, there are some known QTBUGs with Qt 6.7.0 that won't be fixed until 6.7.1 or 6.7.2, so I might revert that and go with Qt 6.6.3 unless 6.7.1 becomes available before we freeze deps. Todo
Also, building and testing on macOS. |
We already add an entire CMakeLists.txt for one dependency via a patch, I forgot which one, but if necessary we can do the same for RNNoise. |
Co-authored-by: PatTheMav <[email protected]>
Co-authored-by: PatTheMav <[email protected]>
8d82c96
to
ad9e2d2
Compare
I reverted these updates:
I changed the deps.qt update to:
I changed libdatachannel to:
On Windows, we had been using an outdated PR which added CMake support, but did not keep up with the host repo's changes. We'll either have to rewrite the CMake support from scratch, or use RNNoise's autotools build system on Windows. Since I prefer to keep the dependencies in sync, I reverted both deps.macos and deps.windows changes. Qt 6.7.0 is a bit too unstable for me to do meaningful testing, so I went with Qt 6.6.3 for now. Qt 6.7.1 might be stable enough, but we can just save the 6.7.x update for later. The libdatachannel change supposedly fixes the issue I ran into, or fixes other known issues. Will confirm in my testing. |
I've retested locally and it seems my build/runtime issues with Qt may have been some issues with unclean build dirs and not building the full archive in the correct order of operations. I've successfully built and run Debug, RelWithDebInfo, and Release with Qt 6.6.3. I've also now successfully tested WHIP with two implementations. I've also tested AMF and NVENC. I updated Sparkle from 2.6.0 to 2.6.1 at their recommendation. Though I do not believe we were immediately affected by the issue (our macOS updates are served via HTTPS), their recommendation was to update anyway. |
Description
Update dependendies as available:
Motivation and Context
Want to keep our deps up to date.
Supersedes #246
Closes #246
Note that neither SRT/libsrt nor mbedTLS are updated here. Building SRT 1.5.x against mbedTLS 3.5.0+ fails because of changes in mbedTLS that needed addressed in libsrt, but there is no new libsrt tag with the needed changes.
Haivision/srt#2842
I initially updated RNNoise, but dropped it because the Windows build actually uses an old PR that added CMake support. We'll either have to rewrite CMake support for the latest stable tag, or we'll have to change our build script to use their preferred build system (autotools).
I did not update librist because versions 0.2.8-0.2.10 have a bug, and there is no new tag. See:
Will post test notes in a follow-up comment.
How Has This Been Tested?
Built deps locally. Built OBS against those deps on Windows 11.
Types of changes
Checklist: