Modernize TH #53
Merged
Modernize TH #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3noch
commented
Apr 2, 2020
|
There are a couple of commented-out instances for DeriveGCompare and DeriveGEq, we need to reinstate/rewrite them. |
3noch
commented
Apr 2, 2020
3noch
commented
Apr 2, 2020
3noch
commented
Apr 2, 2020
3noch
commented
Apr 2, 2020
Ericson2314
reviewed
Apr 2, 2020
meditans
reviewed
Apr 28, 2020
cgibbard
approved these changes
May 6, 2020
|
The build is failing because th-extras 0.5 doesn't exist. We'll have to release that first. |
|
@cgibbard Is this all we need? mokus0/th-extras#6 |
|
The merge of |
Ericson2314
force-pushed
the
cg-modernise-th
branch
from
ddd7f2d to
68dd6d1
Compare
Ericson2314
force-pushed
the
cg-modernise-th
branch
2 times, most recently
from
a96d9bf to
37e3ca5
Compare
Remove dependency on th-extras which was pretty much only needed for one small function. Set lower bound on containers to ensure Data.Map.Merge.Lazy exists.
Ericson2314
force-pushed
the
cg-modernise-th
branch
from
37e3ca5 to
363ef52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From @cgibbard:
This PR is to make deriveGEq, deriveGCompare, and deriveGShow work on many more types.
There were a bunch of various handwritten instances in other projects which I was able to replace with TH.
One thing in particular that I recall fixing were cases where a dictionary argument made Show available for an argument also, cases where there were multiple parameter GADTs and you ended up needing Eq on one of the earlier parameters like
You end up needing an Eq instance on a. I think it was messing this up in some fashion or something close to this.